Set split proportions to None if split column is provided - Issue #198 - #323
Open
sambujangfofana wants to merge 1 commit into
Open
Set split proportions to None if split column is provided - Issue #198#323sambujangfofana wants to merge 1 commit into
sambujangfofana wants to merge 1 commit into
Conversation
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #198,
@aaronphilip19 and I implemented this by defining the default split_proporitions values. We then added a check to see if the provided split column is equal to the default values. If they are not equal, “Labels contains split column yet split_proportions are also provided. Split column in labels takes precedence.” is prompted and split_proportions is set to None.