Replace low-level mouse drag hook - #1413
Open
xoascf wants to merge 5 commits into
Open
Conversation
xoascf
force-pushed
the
drop-low-level-mouse-thing
branch
from
July 31, 2026 01:57
0ec569e to
b0ed714
Compare
Handle taskbar repositioning and resizing through WPF mouse events instead of the low-level mouse hook. The taskbar now captures mouse input directly, updates edge changes and resize steps during drag, and removes the obsolete hook utility.
xoascf
force-pushed
the
drop-low-level-mouse-thing
branch
from
August 14, 2026 01:15
b0ed714 to
c57e43d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
RetroBar/Taskbar.xaml.cs:300
- Checking only the sign of
GetAsyncKeyStatedetects whether Escape is still physically held, not whether Escape ended the native move/size loop. If the key is released beforeWM_EXITSIZEMOVEis processed, this takes the commit path and leaves the dragged edge/size in settings instead of restoring the saved values. Record an Escape key event while the system move/size loop is active and consume that latched cancellation state here.
if (NativeMethods.GetAsyncKeyState((int)System.Windows.Forms.Keys.Escape) < 0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle taskbar repositioning and resizing through WPF mouse events instead of the low-level mouse hook.
The taskbar now captures mouse input directly, updates edge changes and resize steps during drag, and removes the obsolete hook utility.
The system menu tries to replicate the XP behavior to move and resize the taskbar as well.
Also you can now press Esc to cancel a system move/size.