Fixes for PHP 8.5 by removing deprecated code.#113
Open
hostep wants to merge 1 commit into
Open
Conversation
Author
|
@dpdplugin: have you had a chance yet to look into this? Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 changes:
doubleis deprecated in favour of casting tofloatcurl_closeis deprecated, it's fine to fully remove this line as it didn't do anything since PHP 8.0 and your module requires PHP 8.1 at the minimumIn addition, this PR is also needed: dpdconnect/php-sdk#33
@dpdplugin, if you have a bit of time, it would be appreciated if this can be merged soon-ish as we're preparing an upgrade to Magento 2.4.9 with PHP 8.5 and this module stops us from being able to.
Thanks!