Re-enable CurrentCulture_Default_Is_Specific test on iOS CI#130298
Open
matouskozak wants to merge 1 commit into
Open
Re-enable CurrentCulture_Default_Is_Specific test on iOS CI#130298matouskozak wants to merge 1 commit into
matouskozak wants to merge 1 commit into
Conversation
…tvOS Remove SkipOnPlatform attribute to verify if the globalization behavior difference on iOS simulators on CI (issue dotnet#111501) is still reproducing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the CurrentCulture_Default_Is_Specific globalization test on Apple platforms by removing the iOS-family skip, so CI will once again validate that the default CultureInfo.CurrentCulture is specific (non-neutral).
Changes:
- Remove the
[SkipOnPlatform(...)]suppression for iOS/MacCatalyst/tvOS onCurrentCulture_Default_Is_Specific.
Member
Author
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
Contributor
|
Tagging subscribers to 'os-tvos': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
Member
Author
|
Test is passing |
This was referenced Jul 7, 2026
Open
tarekgh
approved these changes
Jul 7, 2026
tarekgh
left a comment
tarekgh
left a comment
Member
There was a problem hiding this comment.
LGTM if the test is not failing anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables the
CurrentCulture_Default_Is_Specifictest on iOS/MacCatalyst/tvOS to check if the globalization behavior difference on iOS simulators on CI (#111501) is still reproducing.The test was disabled in #111032 because
CultureInfo.CurrentCulturewas returningen(neutral) on CI simulators instead ofen-US(specific) as expected. This PR removes theSkipOnPlatformattribute to verify if the issue persists on current CI infrastructure.