-
Notifications
You must be signed in to change notification settings - Fork 302
Adopt standalone Helix monitoring for SDK performance CI #5307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
5da4b7d
ad8f881
b246c00
c813e89
dd921d3
d7d958a
07aebb2
70dd378
75530ba
bff50df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "version": 1, | ||
| "isRoot": true, | ||
| "tools": { | ||
| "microsoft.dotnet.helix.jobmonitor": { | ||
| "version": "11.0.0-beta.26458.103", | ||
| "commands": [ | ||
| "dotnet-helix-job-monitor" | ||
| ] | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,18 @@ parameters: | |
| type: boolean | ||
| default: false | ||
|
|
||
| variables: | ||
| # This entrypoint has one implicit stage. Keep asynchronous sends paired with its monitor. | ||
| - name: EnableHelixJobMonitor | ||
| value: true | ||
| # Matrix legs share a phase and queue. Keep their monitor identities distinct across channels. | ||
| - name: TestRunNamePrefix | ||
| value: '$(Agent.JobName)_' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. none of your workitems today upload test results into AzDO so this doesn't seem to be necessary
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My agent ended up finding another place that this was important (copilot response): The SDK channel matrix shares a phase and queue across independent legs such as With the matrix-expanded Looking at the jobs, this did seem to be a real finding so I am leaning toward keeping the TestRunNamePrefix for now. Can you let me know if you think this is unexpected or if you know there is a different, more correct approach? Otherwise, I will keep this in for now for the properly broken out workitems in the monitor. |
||
| - template: /eng/common/templates/variables/pool-providers.yml | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| # The standalone monitor does not inherit the submitter jobs' variable groups. | ||
| - group: DotNet-HelixApi-Access | ||
|
LoopedBard3 marked this conversation as resolved.
|
||
|
|
||
| resources: | ||
| containers: | ||
| - container: ubuntu_x64_build_container | ||
|
|
@@ -67,3 +79,10 @@ jobs: | |
| jobParameters: | ||
| ${{ if parameters.onlySanityCheck }}: | ||
| onlySanityCheck: true | ||
|
|
||
| - template: /eng/common/core-templates/job/helix-job-monitor.yml | ||
| parameters: | ||
| timeoutInMinutes: 360 | ||
| helixAccessToken: ${{ iif(eq(variables['System.TeamProject'], 'internal'), '$(HelixApiAccessToken)', '') }} | ||
| # Manual runs can legitimately select no workloads. | ||
| allowNoHelixJobs: true | ||
|
Copilot marked this conversation as resolved.
Outdated
|
||
Uh oh!
There was an error while loading. Please reload this page.