Handle NaN and Infinity in CSharpHelper.Literal(float) - #38696
Conversation
- Return float.NaN, float.PositiveInfinity, and float.NegativeInfinity instead of invalid literals such as "NaNf", "Infinityf", and "-Infinityf" that do not compile - Mirrors the existing NaN/Infinity handling for double - Add float NaN/Infinity cases to CSharpHelperTest.Literal_works Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes C# code generation for float literals in CSharpHelper by emitting valid, compilable expressions for NaN and infinities (matching the existing behavior for double).
Changes:
- Update
CSharpHelper.Literal(float)to returnfloat.NaN,float.PositiveInfinity, andfloat.NegativeInfinityfor the corresponding special values. - Add test coverage for these
floatspecial cases inCSharpHelperTest.Literal_works.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/EFCore.Design.Tests/Design/Internal/CSharpHelperTest.cs | Adds float NaN/Infinity InlineData cases to validate the new literal formatting. |
| src/EFCore.Design/Design/Internal/CSharpHelper.cs | Implements special-case handling for float NaN/Infinity to avoid emitting invalid literals like NaNf/Infinityf. |
|
@ilkertskn please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Uh oh!
There was an error while loading. Please reload this page.