[DocsVerifier] Always add file name to error log - #741
Merged
Merged
Conversation
gewarren
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate findings and one test assertion nit remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates DocsVerifier GitHub Actions error annotations to normalize and escape file paths, with corresponding verifier tests.
Changes:
- Normalize and escape annotation paths and messages.
- Update redirect and DocFX verifier tests.
File summaries
| File | Summary |
|---|---|
actions/docs-verifier/tests/GitHub.UnitTests/RedirectTargetVerifierTests.cs |
Verifies redirect annotations. Nit (3 votes): assert the actual redirection file name, not only file=. |
actions/docs-verifier/tests/GitHub.UnitTests/PathVerifierTests.cs |
Verifies annotated DocFX path behavior. |
actions/docs-verifier/src/RedirectionVerifier/RedirectTargetVerifier.cs |
Formats redirect errors. Moderate (3 votes): missing redirection files still emit annotations without file=. |
actions/docs-verifier/src/DocfxVerifier/PathVerifier.cs |
Formats DocFX errors. Moderate (3 votes): null or missing docfx.json branches still emit annotations without file=. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gewarren
enabled auto-merge (squash)
September 11, 2026 20:12
Collaborator
Author
|
@BillWagner Can you hit approve? |
gewarren
disabled auto-merge
September 11, 2026 22:52
Collaborator
Author
|
Going to use superpowers to merge since Bill likely meant to hit Approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.