-
Notifications
You must be signed in to change notification settings - Fork 390
Official build: validate + promote with the newly built Arcade (3/3) #17080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmitche
wants to merge
20
commits into
dotnet:main
Choose a base branch
from
mmitche:dev/arcade-validation-removal/official-build-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+646
−112
Open
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6cbeb52
Run RepoTests in the official build's ValidateSdk stage + add runVali…
mmitche de5a7c3
Promote arcade to '.NET Eng - Latest' using the newly built Arcade (d…
mmitche 8414fa0
Rework official-build validation: signing + self-build + promotion, s…
mmitche e942b69
Reuse existing SignTool.Tests resources for signing validation
mmitche 7f7f36a
Stage signing test VSIXes on the Linux and macOS signing jobs too
mmitche efeb511
Inline the promote-to-latest darc command; share signing copy list vi…
mmitche 9888209
Drop the GitHub PAT from update-packagesource / update-dependencies
mmitche 9fab8ca
Potential fix for pull request finding
mmitche 51942e1
Address PR feedback: cross-platform update-packagesource + promotion-…
mmitche f56f431
Fix Linux signing job pool for 1ES: specify image + os: linux
mmitche d281484
Fix signing artifact download (Release) and promotion-validation GitH…
mmitche d4cc3b2
Use TeamName (not _TeamName) variable so MicroBuild can install on Ma…
mmitche 24da3d3
Fix StrictMode-unsafe \True check in update-packagesource (regression)
mmitche 7b2c50b
Signing validation: bump the built SDK with a cross-platform script (…
mmitche 550158c
Gate promotion validation on the build being assigned to a channel
mmitche 3403b92
use-built-sdk: add each nupkg folder as a flat feed so the new SDK re…
mmitche ab503f4
Add packageSourceMapping entries for local feeds in use-built-sdk.ps1
mmitche bed3132
Make promotion channel gate StrictMode-safe
mmitche b652acc
Fix StrictMode $null.Count in promotion channel gate
mmitche b376ea6
Self-build validation: use the newly built SDK (not the bootstrap SDK)
mmitche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Validates that Arcade build promotion works when driven by the newly built Arcade. One of the | ||
| # parallel jobs of the official build's ValidateSdk stage. See eng/validation/validate-promotion.ps1. | ||
| # | ||
| # NOTE: runs only in the internal official build; not testable locally or in PR. Needs | ||
| # @dotnet/dnceng review and a real official-build run to confirm. | ||
|
|
||
| jobs: | ||
| - template: /eng/common/templates-official/job/job.yml@self | ||
| parameters: | ||
| name: ValidatePromotion | ||
| displayName: Validate promotion (newly built Arcade) | ||
| enableMicrobuild: false | ||
| timeoutInMinutes: 120 | ||
| # The publish-build-assets job writes the BAR build id as the first line of ReleaseConfigs.txt. | ||
| artifacts: | ||
| download: | ||
| name: ReleaseConfigs | ||
| path: release_configs | ||
| variables: | ||
| - group: Publish-Build-Assets | ||
| - template: /eng/common/templates-official/variables/pool-providers.yml@self | ||
| pool: | ||
| name: $(DncEngInternalBuildPool) | ||
| demands: ImageOverride -equals windows.vs2026.amd64 | ||
| preSteps: | ||
| - checkout: self | ||
| clean: true | ||
| steps: | ||
| - powershell: | | ||
| $releaseConfigs = Get-Content "$(System.DefaultWorkingDirectory)/release_configs/ReleaseConfigs.txt" | ||
| $barId = ($releaseConfigs | Select-Object -First 1).Trim() | ||
| if ([string]::IsNullOrEmpty($barId)) { Write-Error "Could not read BAR build id from ReleaseConfigs.txt"; exit 1 } | ||
| Write-Host "BAR build id: $barId" | ||
| Write-Host "##vso[task.setvariable variable=BARBuildId]$barId" | ||
|
Comment on lines
+30
to
+34
|
||
| displayName: Read BAR build id | ||
| # Token with code read/write on the internal AzDO mirror, to push the update-dependencies branch. | ||
| - task: AzureCLI@2 | ||
| displayName: Get AzDO token (WIF) | ||
| name: GetAzDoToken | ||
| inputs: | ||
| azureSubscription: "dnceng-build-rw-code-rw-wif" | ||
| scriptType: ps | ||
| scriptLocation: inlineScript | ||
| inlineScript: | | ||
| $azdoToken = az account get-access-token --resource "499b84ac-1321-427f-aa17-267ca6975798" --query accessToken -o tsv | ||
| if ($LASTEXITCODE -ne 0) { Write-Error "Failed to get AzDO token"; exit 1 } | ||
| Write-Host "##vso[task.setvariable variable=WifAzDoToken;issecret=true]$azdoToken" | ||
| - task: AzureCLI@2 | ||
| displayName: Validate promotion with the newly built Arcade | ||
| inputs: | ||
| azureSubscription: "Darc: Maestro Production" | ||
| scriptType: ps | ||
| scriptLocation: scriptPath | ||
| scriptPath: $(System.DefaultWorkingDirectory)/eng/validation/validate-promotion.ps1 | ||
| arguments: > | ||
| -BuildId $(BARBuildId) | ||
| -Commit $(Build.SourceVersion) | ||
| -AzdoToken $(WifAzDoToken) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.