Skip to content

fix(#24): Fix: The PR does not implement the advertised IPv6 no_proxy CIDR behavior. The actual repo diff only adds metadata and #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dominic097 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#24): Fix: The PR does not implement the advertised IPv6 no_proxy CIDR behavior. The actual repo diff only adds metadata and #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .pulse-demo/sampled-prs/2026-06-24/upstream-pr-7148.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"author": {
"id": "U_kgDOBhlcLg",
"is_bot": false,
"login": "Naitik2302",
"name": ""
},
"baseRefName": "main",
"body": "### Summary\r\nThis PR adds support for IPv6 CIDR ranges in the `no_proxy` environment\r\nvariable when determining proxy bypass behavior.\r\n\r\n### Motivation\r\nWhile Requests already supports IPv4 CIDR ranges and exact IPv6 matches,\r\nIPv6 CIDR ranges were not handled, leading to inconsistent behavior in\r\nIPv6-enabled environments.\r\n\r\n### Testing\r\n- Added unit tests covering IPv6 CIDR matching\r\n- Verified no regressions in existing proxy behavior\r\n",
"createdAt": "2026-01-08T09:51:46Z",
"files": [
{
"additions": 48,
"changeType": "MODIFIED",
"deletions": 7,
"path": "src/requests/utils.py"
},
{
"additions": 23,
"changeType": "ADDED",
"deletions": 0,
"path": "tests/test_ipv6_proxy.py"
}
],

@dominic097 dominic097 Jul 1, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 test · 🟡 Moderate

Referenced IPv6 proxy tests were not added to the real test suite

This metadata snapshot says the upstream change includes an added file tests/test_ipv6_proxy.py, but the actual changed files in this PR are only .pulse-demo/sampled-prs/2026-06-24/upstream-pr-7148.json and src/requests/utils.py. There is no real test module added under tests/, so the advertised IPv6 CIDR behavior has no executable coverage in this repository. User/runtime impact: even if the implementation were later added, this PR provides no protection against regressions in proxy bypass logic. Fix direction: add the real test file under tests/ with cases for matching and non-matching IPv6 CIDR ranges, plus regression coverage for existing IPv4 and exact IPv6 behavior.

P3 · Impact medium (3/5) · Confidence high

🤖 Prompt for AI agents 
Create executable tests in the repository's `tests/` suite for IPv6 `no_proxy` CIDR handling, including positive and negative CIDR matches and regression checks for existing proxy bypass semantics.

Fix with Aziron

🔒 Secure confirmation — opens an authenticated page; the fix is attributed to you. Or reply @aziron fix finding:tests-missing-ipv6-proxy

"headRefName": "ipv6-no-proxy-cidr",
"labels": [],
"number": 7148,
"title": "Add IPv6 CIDR support to no_proxy handling",
"updatedAt": "2026-01-08T09:51:46Z",
"url": "https://github.com/psf/requests/pull/7148"
}
2 changes: 2 additions & 0 deletions src/requests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,3 +1153,5 @@ def rewind_body(prepared_request: PreparedRequest) -> None:
)
else:
raise UnrewindableBodyError("Unable to rewind request body for redirect.")

# Pulse demo seed 2026-06-24: metadata from psf/requests PR #7148

@dominic097 dominic097 Jul 1, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞 correctness · 🟠 Major

Advertised IPv6 no_proxy CIDR support is not implemented

This PR claims to add IPv6 CIDR handling for no_proxy, but the only actual change in src/requests/utils.py is this comment. There are no executable modifications anywhere in the diff to the proxy-bypass helpers in this file, so runtime behavior is unchanged. The accompanying metadata file .pulse-demo/sampled-prs/2026-06-24/upstream-pr-7148.json even lists intended changes to src/requests/utils.py and a new tests/test_ipv6_proxy.py, which confirms the functional patch was not actually applied here. User impact: maintainers may merge expecting IPv6 CIDR proxy bypass to work, but requests in IPv6 environments will still behave exactly as before. Fix direction: apply the real upstream logic changes to the relevant proxy/no_proxy matching code in src/requests/utils.py, not just a metadata comment, and add the corresponding tests.

P2 · Impact high (4/5) · Confidence high

🤖 Prompt for AI agents 
Port the actual IPv6 CIDR `no_proxy` implementation into `src/requests/utils.py`, updating the proxy bypass parsing/matching path that currently handles IPv4 and exact IPv6 cases, and verify behavior with executable tests in the real `tests/` tree.

Fix with Aziron

🔒 Secure confirmation — opens an authenticated page; the fix is attributed to you. Or reply @aziron fix finding:impl-missing-ipv6-no-proxy-cidr