Repository navigation
Conversation
|
Note Greptile reviews are for Doctrine maintainers as a first filter, do not start fixing all the issues immediately unless you think they make sense. A maintainer will give you a green light on this PR for further development or rejection.
[Medium impact] The PR appears safe to merge.
|
UnitOfWork::$partialObjectLoadedFields is keyed by spl_object_id(), but was not cleaned up on detach() or after a deletion was flushed. Once the object was released, PHP could reuse its object id for a new entity, which then inherited the stale entry and got spurious updates scheduled. Fixes doctrine#12784 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
beberlei
force-pushed
the
GH-12784-detach-partial-loaded-fields
branch
from
November 15, 2026 18:56
f509c88 to
a10e505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnitOfWork::$partialObjectLoadedFields is keyed by spl_object_id(), but was not cleaned up on detach() or after a deletion was flushed. Once the object was released, PHP could reuse its object id for a new entity, which then inherited the stale entry and got spurious updates scheduled.
Fixes #12784