Repository navigation
Restore namingStrategy and typedFieldMapper on ClassMetadata wakeup - #12785
Open
akasakariko wants to merge 1 commit into
Open
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
|
Note Greptile reviews are for Doctrine maintainers as a first filter, do not start fixing all the issues immediately unless you think they make sense. A maintainer will give you a green light on this PR for further development or rejection.
[Medium impact] This PR appears safe to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12783
Summary
namingStrategyandtypedFieldMapperfromConfigurationinClassMetadataFactory::wakeupReflection()so custom implementations are preserved after metadata cache unserialization without serializing potentially non-serializable servicesDefaultNamingStrategyandDefaultTypedFieldMapperinClassMetadata::wakeupReflection()when those properties are uninitializedreadonlyfromClassMetadata::$typedFieldMapperso it can be restored consistently alongside$namingStrategytests/Tests/ORM/Mapping/ClassMetadataTest.phpandtests/Tests/ORM/Mapping/ClassMetadataFactoryTest.php