Skip to content

feat: optimize GPT-5.6 defaults and reasoning#3567

Merged
dgageot merged 1 commit into
mainfrom
feat/gpt-5-6-support
Jul 10, 2026
Merged

feat: optimize GPT-5.6 defaults and reasoning#3567
dgageot merged 1 commit into
mainfrom
feat/gpt-5-6-support

Conversation

@aheritier

@aheritier aheritier commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add GPT-5.6 Sol, Terra, and Luna support and refresh the embedded models.dev catalog
  • support the GPT-5.6 reasoning ladder (none, low, medium, high, xhigh, max) while preserving older-model behavior
  • update OpenAI, ChatGPT, Vercel, builtin-agent defaults, examples, schema guidance, and provider documentation
  • propagate trusted OpenAI-vendor identity across native and JS/WASM provider factories, including adversarial and clone-path coverage

Validation

  • task build
  • task test
  • golangci-lint run (0 issues)
  • GOOS=js GOARCH=wasm go test -exec=$(go env GOROOT)/lib/wasm/go_js_wasm_exec ./pkg/model/provider/...
  • git diff --check

The repository custom linter still reports the pre-existing Lint/DeferMutexUnlock warning in untouched pkg/tools/mcp/session_client.go.

Direct OpenAI and ChatGPT examples and defaults use the unsuffixed gpt-5.6 alias. Vercel remains pinned to openai/gpt-5.6-sol because its catalog exposes explicit variants rather than the unsuffixed alias.

References

@aheritier aheritier requested a review from a team as a code owner July 10, 2026 06:07
@aheritier aheritier changed the title feat: add GPT-5.6 model support feat: optimize GPT-5.6 defaults and reasoning Jul 10, 2026
@aheritier aheritier marked this pull request as draft July 10, 2026 06:13
@aheritier aheritier force-pushed the feat/gpt-5-6-support branch from 4381057 to 08b565a Compare July 10, 2026 06:25
@aheritier aheritier marked this pull request as ready for review July 10, 2026 06:26
@aheritier aheritier added area/config For configuration parsing, YAML, environment variables area/docs Documentation changes area/models LLM model integrations and model providers area/providers For features/issues/fixes related to LLM providers (Bedrock, LiteLLM, Qwen, custom, etc.) area/providers/openai For features/issues/fixes related to the usage of OpenAI models kind/feat PR adds a new feature (maps to feat:). Use on PRs only. labels Jul 10, 2026
trungutt
trungutt previously approved these changes Jul 10, 2026
dgageot
dgageot previously approved these changes Jul 10, 2026
@aheritier aheritier force-pushed the feat/gpt-5-6-support branch from 08b565a to 3de40df Compare July 10, 2026 08:25
@aheritier aheritier marked this pull request as draft July 10, 2026 08:32
@aheritier aheritier added the status/needs-rebase PR has merge conflicts or is out of date with main label Jul 10, 2026
@aheritier

Copy link
Copy Markdown
Contributor Author

👋 This PR has merge conflicts with the base branch. Please rebase or merge the latest base branch and resolve them. I've moved it to draft and added status/needs-rebase; it'll be picked back up automatically once the conflicts are cleared.

@aheritier aheritier dismissed stale reviews from dgageot and trungutt via 99a3c80 July 10, 2026 09:39
@aheritier aheritier force-pushed the feat/gpt-5-6-support branch from 3de40df to 99a3c80 Compare July 10, 2026 09:39
@Sayt-0 Sayt-0 marked this pull request as ready for review July 10, 2026 09:56
@dgageot dgageot merged commit a9fd8f0 into main Jul 10, 2026
20 of 32 checks passed
@dgageot dgageot deleted the feat/gpt-5-6-support branch July 10, 2026 09:59

@Sayt-0 Sayt-0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that gpt 5.6 has a max reasoning effort according to the docs : https://developers.openai.com/api/docs/guides/reasoning

@aheritier

Copy link
Copy Markdown
Contributor Author

Good catch—the generic reasoning guide is incomplete here. It says the accepted values are model-dependent, but its generic list currently stops at xhigh.

The GPT-5.6-specific guide explicitly documents max:

  • “GPT-5.6 supports max reasoning effort”
  • Supported efforts are none, low, medium, high, xhigh, and max

https://developers.openai.com/api/docs/guides/latest-model

The implementation gates max to GPT-5.6+ only, so older OpenAI models won’t expose it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config For configuration parsing, YAML, environment variables area/docs Documentation changes area/models LLM model integrations and model providers area/providers/openai For features/issues/fixes related to the usage of OpenAI models area/providers For features/issues/fixes related to LLM providers (Bedrock, LiteLLM, Qwen, custom, etc.) kind/feat PR adds a new feature (maps to feat:). Use on PRs only. status/needs-rebase PR has merge conflicts or is out of date with main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants