[RFC] Add toggle to mute videos by default - #61
Open
sudonym1 wants to merge 1 commit into
Open
Conversation
Owner
|
The UX for this seems really well thought out. Many vibe coded PRs get submitted to this repo and I don't have the time to sort through which are good and which are garbage. If you can clean up any problems, rebase, and test it thoroughly, I'd be happy to review and merge it! |
Author
|
Thanks! I will follow up on this one and prepare a more complete implementation. |
Owner
|
@sudonym1 Wanted to give you a heads up that I just pushed a big rewrite of the media viewer, so you'll need to account for those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sent my agents after a feature I felt was missing from Hydra - that is a toggle to default videos to mute their audio. I borrowed the details from Apollo. When this setting is enabled, videos open muted by default. Pressing Volume Up unmutes. Once one video is unmuted, the next videos are also unmuted as well. Pressing the mute button (under the playback speed button) re-enables mute across videos. Exiting the app and opening it again also re-enables mute.
I haven't looked carefully at the code that my agents cooked up for this. If this approach is useful and this project is open to PRs I will look more closely.