Repository navigation
Fix P0 wire contracts and output shape - #134
Merged
juemerson-at-purestorage merged 2 commits intoAug 20, 2026
Merged
juemerson-at-purestorage merged 2 commits into
juemerson-at-purestorage merged 2 commits into
Conversation
Correct network source and policy-rule query parameters, and stop replication assertions from leaking a success-stream boolean. Refresh derived reports and add regression coverage for each defect. Co-Authored-By: Claude <noreply@anthropic.com>
Adopt the shared module imports in the new regression suites so this branch remains compatible with PR dmann000#133. Co-Authored-By: Claude <noreply@anthropic.com>
juemerson-at-purestorage
added a commit
that referenced
this pull request
Aug 21, 2026
PR #134 fixed #119, removing the two `source.name` records for Invoke-PfbNetworkPing and Invoke-PfbNetworkTrace -- one of them a severity WRONG-RESULTS entry. The committed dead-key report went 85 -> 83. Nothing red, because 85 is a ceiling and a drop is the direction it calls better. That is exactly why it needs re-lowering by hand: left at 85 the gate silently tolerates two brand-new dead keys, and reports safety it is no longer providing. It stays a ceiling rather than becoming a pin. Dead keys legitimately fall as fixes land, and a pin would red every such fix -- making the gate a tax on doing the right thing. The cost of a ceiling is precisely the slack being closed here, so closing it promptly is the discipline the ceiling depends on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invoke-PfbNetworkPingandInvoke-PfbNetworkTraceto send the declaredsourcequery key instead of deadsource.name(Invoke-PfbNetworkPing / Invoke-PfbNetworkTrace: -SourceName sends the wrong query key and always fails with HTTP 400 #119).Assert-PfbRemoteNameNotCoercedfrom leaking$trueinto four replication cmdlets while preserving its terminating validation behavior (Four replication cmdlets emit a stray $true ahead of their results when -RemoteName is used #129).-NameinNew-PfbObjectStoreAccessPolicyRule, send it asnames, and identify the rule inShouldProcesswhile preserving raw-Attributesbodies (New-PfbObjectStoreAccessPolicyRule omits the requirednamesquery parameter; audit the 23 cmdlets that build an empty@{}body #106 Part 1).Design decisions
namesquery parameter; audit the 23 cmdlets that build an empty@{}body #106 Part 2 typed rule fields outside this PR; this change adds only the mandatory selector needed for a valid request.-Attributesbehavior.Test plan
google.comboth succeeded with-SourceName vir0; responses echoedsource: vir0, proving the correctedsourcequery key was accepted. IPv4 ping returned 3/3 replies at ~11.5 ms, and trace completed from all three components in 24-25 hops.namesquery parameter; audit the 23 cmdlets that build an empty@{}body #106 Part 1 reached FB-A with bothnamesandpolicy_names; the array rejected the harness-required hyphenatedpslivetest-rule name because rule names must be alphanumeric. A valid alphanumeric name is blocked by the harness prefix rail. No residue remained, and the rail was not bypassed.Closes #119.
Closes #129.
Addresses #106 Part 1.
🤖 Generated with Claude Code