Skip to content

Added accessibilityEnabled to allow the accessibility feature to be disabled - #35

Open
peter-lewis wants to merge 2 commits into
diverted247:masterfrom
peter-lewis:AccessibilityOptional
Open

Added accessibilityEnabled to allow the accessibility feature to be disabled#35
peter-lewis wants to merge 2 commits into
diverted247:masterfrom
peter-lewis:AccessibilityOptional

Conversation

@peter-lewis

Copy link
Copy Markdown

Added accessibilityEnabled to allow the accessibility feature to be disabled

Added accessibilityEnabled to enable the accessibility to be disabled
Added some fixes to handle leading and trailing spaces on lines properly
@jedateach

jedateach commented Jan 7, 2020

Copy link
Copy Markdown

Hi Peter - just wondering if you could update your PR description to explain why disabling accessibility is important?

@peter-lewis

Copy link
Copy Markdown
Author

Wow, time machine on this one!
If I remember correctly, there were bugs with the implementation which potentially caused older browsers to blow up (gotta love IE) when it would try to render the txt, but I might be forgetting? This was from just about 2 years ago!

@jedateach

Copy link
Copy Markdown

Yeah fair enough. I'm just expanding my understanding of the library to decide whether to adopt it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants