Skip to content

sparse: Fix CSC column panic messages and Cholesky solve docs #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrKyomoto wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

sparse: Fix CSC column panic messages and Cholesky solve docs #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nalgebra-sparse/src/csc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ impl<T> CscMatrix<T> {
#[inline]
#[must_use]
pub fn col(&self, index: usize) -> CscCol<'_, T> {
self.get_col(index).expect("Row index must be in bounds")
self.get_col(index).expect("Column index must be in bounds")
}

/// Mutable column access for the given column index.
Expand All @@ -367,7 +367,7 @@ impl<T> CscMatrix<T> {
#[inline]
pub fn col_mut(&mut self, index: usize) -> CscColMut<'_, T> {
self.get_col_mut(index)
.expect("Row index must be in bounds")
.expect("Column index must be in bounds")
}

/// Return the column at the given column index, or `None` if out of bounds.
Expand Down
4 changes: 2 additions & 2 deletions nalgebra-sparse/src/factorization/cholesky.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ impl<T: RealField> CscCholesky<T> {
///
/// # Panics
///
/// Panics if `B` is not square.
/// Panics if the number of rows of `B` differs from the dimension of the factorized matrix.
#[must_use = "Did you mean to use solve_mut()?"]
pub fn solve<'a>(&'a self, b: impl Into<DMatrixView<'a, T>>) -> DMatrix<T> {
let b = b.into();
Expand All @@ -277,7 +277,7 @@ impl<T: RealField> CscCholesky<T> {
///
/// # Panics
///
/// Panics if `b` is not square.
/// Panics if the number of rows of `B` differs from the dimension of the factorized matrix.
pub fn solve_mut<'a>(&'a self, b: impl Into<DMatrixViewMut<'a, T>>) {
let expect_msg = "If the Cholesky factorization succeeded,\
then the triangular solve should never fail";
Expand Down