Allow generating NOT MATERIALIZED queries & call-site simplification - #142
Open
terencehonles wants to merge 1 commit into
Open
Allow generating NOT MATERIALIZED queries & call-site simplification#142terencehonles wants to merge 1 commit into
NOT MATERIALIZED queries & call-site simplification#142terencehonles wants to merge 1 commit into
Conversation
terencehonles
force-pushed
the
allow-generating-NOT-MATERIALIZED-queries
branch
from
July 14, 2026 11:07
d66e825 to
5c82b12
Compare
terencehonles
changed the title
NOT MATERIALIZED queriesNOT MATERIALIZED queries & call-site simplification
This change allows generating both `MATERIALIZED` and `NOT MATERIALIZED`
queries, deprecates name & materialized as positional arguments, moves
the default CTE name ("cte") into the initializer so callers can use
`None` and updates pytest to error on deprecation warnings.
terencehonles
force-pushed
the
allow-generating-NOT-MATERIALIZED-queries
branch
from
July 14, 2026 11:36
5c82b12 to
0fbea80
Compare
Contributor
|
This does four things in one commit
I would prefer they had been done in separate commits.
Can you say a bit more about why this is necessary?
Why would a caller want to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows generating both
MATERIALIZEDandNOT MATERIALIZEDqueries, deprecates name & materialized as positional arguments, moves the default CTE name ("cte") into the initializer so callers can useNoneand updates pytest to error on deprecation warnings.