-
Notifications
You must be signed in to change notification settings - Fork 38
4064: Announce dynamic content updates #4285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4622d75
5b29c89
18ab759
6c9c5d9
1043ba9
19e83bd
3dd37e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ const Container = styled.View<{ $padding: boolean }>` | |
| ${props => props.$padding && `padding: 0 ${dimensions.pageContainerPaddingHorizontal}px 8px;`} | ||
| ` | ||
| const SpaceForTts = styled.View<{ $ttsPlayerVisible: boolean }>` | ||
| height: ${props => (props.$ttsPlayerVisible ? dimensions.ttsPlayerHeight : 0)}px; | ||
| height: ${props => (props.$ttsPlayerVisible ? dimensions.ttsPlayerHeight + dimensions.bottomNavigationHeight : 0)}px; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for catching it 🙈
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hmm I dont have any solution for this, except for removing additional height and leaving it to cover the last update date 🤔
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry I think the issue is not from here its from the sceneStyle: bottomTabsVisible
? undefined
: { paddingBottom: insets.bottom + dimensions.bottomNavigationHeight },
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, I mean this. I added it to add a height to not cover the last update date, but then it breaks the whole view when there are no navigation tabs...
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can think of 2 possible solutions for the spacing at aschaffenburg:
insetBottom={bottom + (bottomTabsVisible ? dimensions.bottomNavigationHeight : 0)}now the difficulty is where can we get the const { regionCode } = useAppContext()
const { data: regions } = useLoadRegions()
const region = regions?.find(it => it.code === regionCode)
const bottomTabsVisible = !!(
region?.placesEnabled ||
region?.localNewsEnabled ||
region?.tuNewsEnabled ||
region?.eventsEnabled
)
|
||
| ` | ||
|
|
||
| type PageProps = { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { css } from 'styled-components/native' | ||
|
|
||
| export const elevatedStyle = css` | ||
| shadow-color: ${props => props.theme.colors.onSurface}; | ||
| shadow-offset: 0 2px; | ||
| shadow-opacity: 0.2; | ||
| shadow-radius: 3px; | ||
| elevation: 5; | ||
| ` |

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hide the chatFab when the Tts player is open because it's under the player and can't be open anyway.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's ask @ulyanahoy-cloud, whether she has other ideas? @ulyanahoy-cloud what do you think about removing chat button or fitting them together by making the dialog smaller when the

read aloud playeris activated? Currently chat button is underneath of theread aloud playerdialog 💭