Skip to content

fix: deflake //rs/tests/consensus/upgrade:upgrade_downgrade_unassigned_nodes_test #11412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierugo-dfinity merged 2 commits into from
Sep 4, 2026
Merged

fix: deflake //rs/tests/consensus/upgrade:upgrade_downgrade_unassigned_nodes_test #11412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a634e05
fix: deflake //rs/tests/consensus/upgrade:upgrade_downgrade_unassigne…
basvandijk Sep 1, 2026
8761942
refactor: reuse constants
pierugo-dfinity Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rs/tests/consensus/upgrade/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ system_test_nns(
"long_test",
],
test_driver_target = ":upgrade_downgrade_unassigned_test_bin",
test_timeout = "eternal",
)

system_test_nns(
Expand All @@ -174,6 +175,7 @@ system_test_nns(
"long_test",
],
test_driver_target = ":upgrade_downgrade_unassigned_test_bin",
test_timeout = "eternal",
)

system_test_nns(
Expand Down
13 changes: 13 additions & 0 deletions rs/tests/consensus/upgrade/upgrade_downgrade_unassigned_nodes_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Success::

end::catalog[] */

use std::time::Duration;

use anyhow::Result;
use anyhow::bail;
use ic_consensus_system_test_upgrade_common::elect_target_version;
Expand All @@ -40,6 +42,15 @@ use ic_types::ReplicaVersion;
use slog::Logger;
use slog::info;

// The test performs two sequential GuestOS upgrades of the unassigned node,
// each of which is polled with a 600s retry budget (see
// `upgrade_unassigned_nodes` below). The driver's default per-test timeout of
// 10 minutes cannot even cover a single exhausted poll, so give the test an
// explicit budget that covers its own worst case (2 x 600s polling + proposal
// handling + slack), like its siblings in this package do.
const UP_DOWNGRADE_OVERALL_TIMEOUT: Duration = Duration::from_secs(30 * 60);
const UP_DOWNGRADE_PER_TEST_TIMEOUT: Duration = Duration::from_secs(25 * 60);
Comment thread
pierugo-dfinity marked this conversation as resolved.
Outdated

fn setup(env: TestEnv) {
InternetComputer::new()
.add_fast_single_node_subnet(SubnetType::System)
Expand Down Expand Up @@ -96,6 +107,8 @@ fn upgrade_downgrade_unassigned_nodes(env: TestEnv) {

fn main() -> Result<()> {
SystemTestGroup::new()
.with_overall_timeout(UP_DOWNGRADE_OVERALL_TIMEOUT)
.with_timeout_per_test(UP_DOWNGRADE_PER_TEST_TIMEOUT)
.with_setup(setup)
.add_test(systest!(upgrade_downgrade_unassigned_nodes))
.execute_from_args()?;
Expand Down
Loading