test(cketh): derive e2e sweep parameters from get_minter_info and re-send a stale authorization - #11374
Conversation
There was a problem hiding this comment.
Pull request overview
Updates ckETH end-to-end sweep tests to derive runtime configuration from get_minter_info and verify stale EIP-7702 authorization reuse.
Changes:
- Derives sweeper addresses and deposit minimums dynamically.
- Adds a repeated-deposit stale-authorization test.
- Adds Anvil helpers for authorization nonce and delegation inspection.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rs/ethereum/cketh/test_utils/src/live.rs |
Adds runtime minter-info lookups and deposit detection helpers. |
rs/ethereum/cketh/test_utils/src/lib.rs |
Updates sweeper-address documentation. |
rs/ethereum/cketh/test_utils/src/anvil.rs |
Adds authorization nonce and delegation designator helpers. |
rs/ethereum/cketh/minter/tests/deposit_from_cex.rs |
Derives test parameters dynamically and adds the repeated-deposit scenario. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
83b23e1 to
33e32cd
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
…info Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
…cy status assert Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
…nd minimum lookups Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
…ls can resolve Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
33e32cd to
183d86c
Compare
…ion chains Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
…sit-e2e-follow-ups Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD
|
✅ No security or compliance issues detected. Reviewed everything up to e6af0af. Security Overview
Detected Code Changes
|
mbjorkqvist
left a comment
There was a problem hiding this comment.
Thanks @gregorydemay!
…ng its pair The mint follows the log scrape while a swept pair only leaves the sweep queue on finalization, one timer apart. Re-registering while the pair is still queued reports the stale detection instead of arming it afresh, so the second deposit would never be scanned. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PmyHh2sx7x38LEgHGkmNud
|
🤖 Flakiness check on a36588b: ran
The per-run durations are tightly clustered, so the tick-driven waits (including the new |
…sit-e2e-follow-ups # Conflicts: # rs/ethereum/cketh/test_utils/src/live.rs
Follow-ups to #11363:
get_minter_info(feat(cketh): expose the sweeper address in MinterInfo #11240).cketh.rsandckerc20.rs. State-changing steps (funding the fee account, upgrading the minter) and minter endpoint calls (deposit_erc20) are visible in each test instead of being buried in the test fixtures.🤖 Generated with Claude Code
https://claude.ai/code/session_01YK3ggw1xtE3HZTGGBu66oD