#2253: Fix structure and log documentation - #2272
Conversation
1787cce to
9768f81
Compare
Coverage Report for CI Build 32145967611Coverage increased (+0.02%) to 72.945%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
samuelkos17
left a comment
There was a problem hiding this comment.
Great Work! Thanks a lot for updating the documentation, i see no problem with your changes so I'll move this to In Review 😄
hohwille
left a comment
There was a problem hiding this comment.
@krystynaShatkovska thank you for your PR. Nice that you created and improved this documentation and figured out the details to describe this properly. 👍
I added some insights and suggest to omit the cleanup status - your hints are correct but then we very soon need another PR removing that and we even might forget about it.
Most likely cleanup will be improved accordingly before many users have found and read the new documentation. 😄
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
|
@hohwille thank you for recommendations! |
since a suggestions was applied where GItHub got confused about the markup and detected the start of a code block as the end of the suggestion.
hohwille
left a comment
There was a problem hiding this comment.
@krystynaShatkovska thanks for the review rework. Can you please check the CHANGELOG so I can finally merge? Thanks in advance.
This PR fixes #2253
Implemented changes:
structure.adocto reflect the current IDEasy directory structure.$IDE_ROOT/_ide/logs.tmp.urls.log.adocwith:Testing instructions
issue-2253-doc-structure-logsChecklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»In Progressand assigned to you or there is no issue (might happen for very small PRs)CHANGELOG.adocunless issue is labeled withinternal