Skip to content

Fix crash due to incorrect OSReport() usage. #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaryOderNichts merged 2 commits into from
Aug 22, 2026
+9 −9
Merged

Fix crash due to incorrect OSReport() usage. #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0398bb1
Fixed incorrect usage of OSReport in log_cafe.
Aug 22, 2026
1d973ee
Make all OSReport messages end with a newline.
Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/libwhb/src/log_cafe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ cafeLogHandler(const char *msg)
if (msg[length - 1] != '\n') {
OSReport("%s\n", msg);
} else {
OSReport(msg);
OSReport("%s", msg);
}
}

Expand Down
8 changes: 4 additions & 4 deletions libraries/nn_erreula/nn_erreula.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ Create(const CreateArg &args)
bool result = true;

if (!args.workMemory) {
OSReport("ERREULA: Create failed. CreateArg.workMemory is NULL.");
OSReport("ERREULA: Create failed. CreateArg.workMemory is NULL.\n");
return false;
}

if (!args.fsClient) {
OSReport("ERREULA: Create failed. CreateArg.fsClient is NULL.");
OSReport("ERREULA: Create failed. CreateArg.fsClient is NULL.\n");
return false;
}

Expand All @@ -114,7 +114,7 @@ Create(const CreateArg &args)
dynloadAcquireUseSize, kRplAcquireBufferSize);

if (dynloadAcquireUseSize > kRplAcquireBufferSize) {
OSReport("ERREULA: Create failed. dynload_acquire_use_size > kRplAcquireBufferSize.");
OSReport("ERREULA: Create failed. dynload_acquire_use_size > kRplAcquireBufferSize.\n");
result = false;
goto out;
}
Expand Down Expand Up @@ -147,7 +147,7 @@ Create(const CreateArg &args)
kWorkMemorySize - kRplAcquireBufferSize,
4);
if (!workMemory) {
OSReport("ERREULA: Create failed. framework_buffer == NULL.");
OSReport("ERREULA: Create failed. framework_buffer == NULL.\n");
result = false;
goto out;
} else {
Expand Down
8 changes: 4 additions & 4 deletions libraries/nn_swkbd/nn_swkbd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,12 @@ Create(const CreateArg &args)
bool result = true;

if (!args.workMemory) {
OSReport("SWKBD: Create failed. CreateArg.workMemory is NULL.");
OSReport("SWKBD: Create failed. CreateArg.workMemory is NULL.\n");
return false;
}

if (!args.fsClient) {
OSReport("SWKBD: Create failed. CreateArg.fsClient is NULL.");
OSReport("SWKBD: Create failed. CreateArg.fsClient is NULL.\n");
return false;
}

Expand Down Expand Up @@ -132,7 +132,7 @@ Create(const CreateArg &args)
dynloadAcquireUseSize, sRplAcquireBufferSize);

if (dynloadAcquireUseSize > sRplAcquireBufferSize) {
OSReport("SWKBD: Create failed. dynload_acquire_use_size > sRplAcquireBufferSize.");
OSReport("SWKBD: Create failed. dynload_acquire_use_size > sRplAcquireBufferSize.\n");
result = false;
goto out;
}
Expand Down Expand Up @@ -178,7 +178,7 @@ Create(const CreateArg &args)
GetWorkMemorySize(args.unk_0x08) - sRplAcquireBufferSize,
4);
if (!workMemory) {
OSReport("SWKBD: Create failed. framework_buffer == NULL.");
OSReport("SWKBD: Create failed. framework_buffer == NULL.\n");
result = false;
goto out;
} else {
Expand Down
Loading