Replace prebuild upload with gh release create for immutable releases#294
Open
tidy-dev wants to merge 1 commit into
Open
Replace prebuild upload with gh release create for immutable releases#294tidy-dev wants to merge 1 commit into
tidy-dev wants to merge 1 commit into
Conversation
- Change permissions from contents: read to contents: write - Replace yarn upload (prebuild --upload-all) with gh release create --draft - CI now creates a draft release with assets; human publishes to make it immutable - Update release docs to reflect new workflow Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
prebuild --upload-allrelease mechanism withgh release create --draftto support immutable releases.Problem
prebuildcreates a non-draft published release and then uploads assets in separate API calls. With immutable releases enabled, those uploads are rejected (422: Cannot upload assets to an immutable release). This is a known open issue in prebuild.Solution
yarn uploadwithgh release create ${{ github.ref_name }} prebuilds/*.tar.gz --generate-notes --draftcontents: readtocontents: write(required forgh release create)Validation
Tested end-to-end on a fork (
tidy-dev/registry-js) with immutable releases enabled:prebuildflow fails: https://github.com/tidy-dev/registry-js/actions/runs/28388707501gh release createflow succeeds: https://github.com/tidy-dev/registry-js/actions/runs/28390034974Related