XSUP 75257 - Add sanitize_large_ints function to handle large ThreatConnect object IDs - #45638
Conversation
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
Coverage Report
|
||||||||||||||||||||||||||||||
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your work on the ThreatConnect integration updates. I've left a few suggestions to help polish the code, primarily updating the Client class to inherit from ContentClient instead of BaseClient. There are also a few minor notes regarding adding type hints, handling negative large integers, expanding test coverage, and adjusting the release notes for Cortex branding. Great job overall!
Additionally, please address the following file-level notes:
Packs/ThreatConnect/Integrations/ThreatConnectV3/ThreatConnectV3.py: TheClientclass inherits fromBaseClientinstead ofContentClient.
@DanielTal87, @lironcohen272 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-75257
Description
Fixed an issue where large ThreatConnect object IDs could lose numerical precision when processed by XSOAR, resulting in incorrect IDs being used by downstream commands. Large integer values are now returned as strings to preserve their accuracy.