Skip to content

XSUP 75257 - Add sanitize_large_ints function to handle large ThreatConnect object IDs - #45638

Merged
lironcohen272 merged 4 commits into
masterfrom
XSUP-75257/fix-xsoar8-usb-threat-connect-indicators-object-ids
Aug 25, 2026
Merged

XSUP 75257 - Add sanitize_large_ints function to handle large ThreatConnect object IDs#45638
lironcohen272 merged 4 commits into
masterfrom
XSUP-75257/fix-xsoar8-usb-threat-connect-indicators-object-ids

Conversation

@lironcohen272

Copy link
Copy Markdown
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-75257

Description

Fixed an issue where large ThreatConnect object IDs could lose numerical precision when processed by XSOAR, resulting in incorrect IDs being used by downstream commands. Large integer values are now returned as strings to preserve their accuracy.

@lironcohen272 lironcohen272 self-assigned this Aug 24, 2026
@lironcohen272 lironcohen272 added ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. docs-approved labels Aug 24, 2026
@lironcohen272 lironcohen272 changed the title Xsup 75257 - Add sanitize_large_ints function to handle large ThreatConnect object IDs XSUP 75257 - Add sanitize_large_ints function to handle large ThreatConnect object IDs Aug 24, 2026
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ThreatConnect/Integrations/ThreatConnectV3
   ThreatConnectV3.py5358983%147, 153, 163, 171, 174–176, 181–182, 188–189, 191, 196, 198–201, 204, 211–214, 230, 234–236, 243–244, 272, 274, 326, 416–423, 497, 502–504, 513–514, 521, 558–559, 753, 819, 824–825, 827–828, 880–881, 895–896, 911, 913, 923, 1956, 2043–2047, 2197–2201, 2312–2316, 2338, 2363–2373
TOTAL5358983% 

Tests Skipped Failures Errors Time
47 0 💤 0 ❌ 0 🔥 3.331s ⏱️

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Aug 24, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your work on the ThreatConnect integration updates. I've left a few suggestions to help polish the code, primarily updating the Client class to inherit from ContentClient instead of BaseClient. There are also a few minor notes regarding adding type hints, handling negative large integers, expanding test coverage, and adjusting the release notes for Cortex branding. Great job overall!

Additionally, please address the following file-level notes:

  • Packs/ThreatConnect/Integrations/ThreatConnectV3/ThreatConnectV3.py: The Client class inherits from BaseClient instead of ContentClient.

@DanielTal87, @lironcohen272 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/ThreatConnect/Integrations/ThreatConnectV3/ThreatConnectV3.py Outdated
Comment thread Packs/ThreatConnect/Integrations/ThreatConnectV3/ThreatConnectV3.py Outdated
Comment thread Packs/ThreatConnect/Integrations/ThreatConnectV3/ThreatConnectV3.py
Comment thread Packs/ThreatConnect/ReleaseNotes/3_1_24.md Outdated
@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 4d529b0406d1d60d

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@lironcohen272 lironcohen272 added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 25, 2026
@lironcohen272
lironcohen272 enabled auto-merge (squash) August 25, 2026 09:17
@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@lironcohen272
lironcohen272 merged commit 329a3da into master Aug 25, 2026
33 of 35 checks passed
@lironcohen272
lironcohen272 deleted the XSUP-75257/fix-xsoar8-usb-threat-connect-indicators-object-ids branch August 25, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants