GCP: Cloud Run migration - #45636
Conversation
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
Coverage Report
|
||||||||||||||||||||||||||||||
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
RotemAmit
added
the
ready-for-ai-review
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your contribution to the GCP integration. I've reviewed the changes and have a few minor adjustments for you to make. Please update the pagination implementation to follow our standard argument contract, ensure all YAML descriptions start with "The " and end with a period, and add format examples to any date/time outputs. Thanks again for your hard work!
@RotemAmit please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| project_id = args.get("project_id") | ||
| # "-" is the API's wildcard for "every location". | ||
| region = args.get("region") or "-" | ||
| limit = arg_to_number(args.get("limit")) |
There was a problem hiding this comment.
Please update the pagination implementation to follow the standard argument contract.
| with the continuation token under `GCP.CloudRun.LocationsNextToken`. | ||
| """ | ||
| project_id = args.get("project_id") | ||
| limit = arg_to_number(args.get("limit")) |
There was a problem hiding this comment.
Please update the pagination implementation to follow the standard argument contract.
| required: false | ||
| - name: limit | ||
| defaultValue: '50' | ||
| description: "Maximum number of results to return. Acceptable values are 1 to 500, inclusive." |
There was a problem hiding this comment.
Argument descriptions must start with "The " and end with a period.
| - name: next_token | ||
| description: The token for the next set of items to return, used for pagination. | ||
| - name: filter | ||
| description: 'A filter expression for the functions listed in the response. For example, to return only active functions, use state="ACTIVE".' |
There was a problem hiding this comment.
Argument descriptions must start with "The " and end with a period.
| description: 'The sort order of the returned functions, as a comma-separated list of fields. Append " desc" to a field to sort it in descending order. For example, name desc.' | ||
| outputs: | ||
| - contextPath: GCP.CloudRun.Functions.name | ||
| description: 'A user-defined name of the function. Function names are unique globally and match the pattern projects/*/locations/*/functions/*.' |
There was a problem hiding this comment.
Output descriptions must start with "The " and end with a period.
| description: 'Whether the function is 1st Gen or 2nd Gen. Possible values are: ENVIRONMENT_UNSPECIFIED, GEN_1, GEN_2.' | ||
| type: String | ||
| - contextPath: GCP.CloudRun.Functions.upgradeInfo | ||
| description: Upgrade information for this function. |
There was a problem hiding this comment.
Output descriptions must start with "The " and end with a period.
| description: The deployed URL of the function. | ||
| type: String | ||
| - contextPath: GCP.CloudRun.Functions.kmsKeyName | ||
| description: 'Resource name of a KMS crypto key (managed by the user) used to encrypt/decrypt function resources. Matches the pattern projects/{project}/locations/{location}/keyRings/{key_ring}/cryptoKeys/{crypto_key}.' |
There was a problem hiding this comment.
Output descriptions must start with "The " and end with a period.
| description: 'Resource name of a KMS crypto key (managed by the user) used to encrypt/decrypt function resources. Matches the pattern projects/{project}/locations/{location}/keyRings/{key_ring}/cryptoKeys/{crypto_key}.' | ||
| type: String | ||
| - contextPath: GCP.CloudRun.Functions.satisfiesPzs | ||
| description: Reserved for future use. |
There was a problem hiding this comment.
Output descriptions must start with "The " and end with a period.
| description: Reserved for future use. | ||
| type: Boolean | ||
| - contextPath: GCP.CloudRun.Functions.createTime | ||
| description: The create timestamp of the function. This is only applicable to 2nd Gen functions. |
There was a problem hiding this comment.
Date/time outputs must include a format example in their description.
| description: The create timestamp of the function. This is only applicable to 2nd Gen functions. | ||
| type: Date | ||
| - contextPath: GCP.CloudRun.Functions.satisfiesPzi | ||
| description: Reserved for future use. |
There was a problem hiding this comment.
Output descriptions must start with "The " and end with a period.
3 participants
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
related: https://jira-dc.paloaltonetworks.com/browse/CRTX-215177
Description
Migrating the Google Cloud Functions command to the unified GCP, with the name Cloud Run Functions, as it was rebranded. Along with the usage of v2, instead of v1 which in deprecation process.
Must have