CIAC-17779: Align asset fetch parameters with supportedModules rules - #45634
Conversation
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
|
@marketplace-ai-reviewer start review |
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your contribution. I've reviewed the PR and noticed a few minor formatting issues to tidy up.
Mainly, there are some YAML indentation inconsistencies across several integration files (CrowdStrike, Rapid7, Tenable, and Qualys), specifically around the new parameter blocks, hidden keys, and supportedModules lists. There's also a quick suggestion to add the vendor name to the Rapid7 pack metadata keywords.
Thanks again, and let me know if you have any questions!
Additionally, please address the following file-level notes:
Packs/Rapid7_Nexpose/pack_metadata.json: Consider adding the vendor name "Rapid7" to thekeywordslist in this file.
@DanielTal87, @Shellyber, @talzich, @JasBeilin, @dtroushinsky please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
…rikeFalcon.yml Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com>
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-17779
Description
Aligns the Fetch Assets configuration parameters (
isFetchAssets,assetsFetchInterval) of the asset integrations with the requiredsupportedModules/hiddenrules. For each of these params,supportedModulesmust be a subset of[xsiam, exposure_management]and the params should be hidden onxsoar.Must have