Skip to content

CIAC-17779: Align asset fetch parameters with supportedModules rules - #45634

Merged
dtroushinsky merged 6 commits into
masterfrom
CIAC-17779
Aug 25, 2026
Merged

CIAC-17779: Align asset fetch parameters with supportedModules rules#45634
dtroushinsky merged 6 commits into
masterfrom
CIAC-17779

Conversation

@dtroushinsky

Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-17779

Description

Aligns the Fetch Assets configuration parameters (isFetchAssets, assetsFetchInterval) of the asset integrations with the required supportedModules / hidden rules. For each of these params, supportedModules must be a subset of [xsiam, exposure_management] and the params should be hidden on xsoar.

Must have

  • Tests
  • Documentation

@dtroushinsky dtroushinsky added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Aug 24, 2026
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@dtroushinsky

Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer start review

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Coverage

Tests Skipped Failures Errors Time
751 0 💤 0 ❌ 0 🔥 20.951s ⏱️

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution. I've reviewed the PR and noticed a few minor formatting issues to tidy up.

Mainly, there are some YAML indentation inconsistencies across several integration files (CrowdStrike, Rapid7, Tenable, and Qualys), specifically around the new parameter blocks, hidden keys, and supportedModules lists. There's also a quick suggestion to add the vendor name to the Rapid7 pack metadata keywords.

Thanks again, and let me know if you have any questions!

Additionally, please address the following file-level notes:

  • Packs/Rapid7_Nexpose/pack_metadata.json: Consider adding the vendor name "Rapid7" to the keywords list in this file.

@DanielTal87, @Shellyber, @talzich, @JasBeilin, @dtroushinsky please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/Rapid7_Nexpose/Integrations/Rapid7_Nexpose/Rapid7_Nexpose.yml
Comment thread Packs/Tenable_sc/Integrations/Tenable_sc/Tenable_sc.yml
Comment thread Packs/Tenable_sc/Integrations/Tenable_sc/Tenable_sc.yml
Comment thread Packs/qualys/Integrations/Qualysv2/Qualysv2.yml
Comment thread Packs/qualys/Integrations/Qualysv2/Qualysv2.yml
@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 488e204f436bc8a8

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@dtroushinsky
dtroushinsky enabled auto-merge (squash) August 25, 2026 08:36
@dtroushinsky
dtroushinsky merged commit baae14e into master Aug 25, 2026
23 of 25 checks passed
@dtroushinsky
dtroushinsky deleted the CIAC-17779 branch August 25, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants