Skip to content

HY/CRTX-275112/TelematryFailuresSlackListMessages - #45629

Open
hyaffe839 wants to merge 6 commits into
masterfrom
HY/CRTX-275112/TelematryFailuresSlackListMessages
Open

HY/CRTX-275112/TelematryFailuresSlackListMessages#45629
hyaffe839 wants to merge 6 commits into
masterfrom
HY/CRTX-275112/TelematryFailuresSlackListMessages

Conversation

@hyaffe839

Copy link
Copy Markdown
Contributor

״

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

CRTX-275112

Description

PR Description:

Fixes CRTX-275112 — slack-get-conversation-history 35.71% success rate across 14 executions.

This PR migrates all error paths in slack-get-conversation-history to the standardized CortexError hierarchy (CortexMissingArgError, CortexResourceNotFoundError, CortexExternalApiError), and adds a try/except SlackApiError wrapper around the conversations.history API call.

Must have

  • Tests
  • Documentation

@hyaffe839 hyaffe839 self-assigned this Aug 24, 2026
@hyaffe839
hyaffe839 requested a review from mmhw August 24, 2026 11:43
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@hyaffe839 hyaffe839 changed the title HY/CRTX-275112/TelematryFailuresSlackListMessages״ HY/CRTX-275112/TelematryFailuresSlackListMessages Aug 24, 2026
@hyaffe839 hyaffe839 added docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Slack/Integrations/SlackV3
   SlackV3.py193845276%155, 182, 184–188, 190, 208–210, 222, 236, 240, 278, 291, 303, 312, 349, 373–375, 387, 397, 418, 421, 447, 449, 451–453, 456–457, 459–463, 466–467, 470–471, 474–475, 478, 480–481, 484–487, 489, 492–493, 496–499, 501–503, 544, 616–617, 624–635, 637–640, 642, 645–646, 652–653, 663–664, 666, 739, 765, 902–903, 905–907, 909–912, 914, 930, 938–939, 998, 1055–1056, 1089, 1099, 1103–1114, 1135, 1202–1207, 1218–1225, 1233, 1252, 1258, 1291–1292, 1339, 1372, 1375, 1395–1396, 1402–1408, 1411–1412, 1414–1426, 1428–1431, 1465–1466, 1491–1500, 1524, 1536, 1607–1608, 1611–1612, 1615–1616, 1619–1620, 1623–1624, 1627–1628, 1630, 1637–1642, 1649, 1652–1656, 1658–1663, 1665–1670, 1680–1681, 1688–1695, 1728–1729, 1801, 1822, 1828, 1880, 1890–1891, 1985, 2039, 2043–2044, 2085, 2095–2096, 2105, 2135, 2212–2214, 2216, 2223–2227, 2235, 2246, 2261–2262, 2265–2269, 2272–2273, 2276–2280, 2284–2290, 2293–2299, 2312–2313, 2363, 2370–2372, 2446–2447, 2471, 2506, 2509, 2534–2535, 2539, 2550, 2564, 2569–2570, 2602–2603, 2614–2615, 2638, 2655, 2733, 2788–2789, 2792, 2796, 2806, 2809–2811, 2816, 2819, 2863, 2866, 2869, 2876–2877, 2879, 2902, 2905–2906, 2981, 3113, 3138–3141, 3143, 3145–3146, 3148, 3152–3154, 3158–3160, 3162–3163, 3165–3166, 3168, 3170, 3172–3173, 3183, 3199, 3223, 3233, 3235, 3240–3241, 3276–3277, 3283, 3285, 3289, 3298, 3301–3303, 3311–3312, 3314, 3337–3338, 3344, 3368, 3373–3376, 3378, 3458–3460, 3462–3463, 3467, 3527, 3531–3532, 3536, 3543–3544, 3554, 3556, 3576–3580, 3639–3640, 3642, 3644, 3686–3689, 3691–3696, 3767, 3790, 3792–3795, 3797–3798, 3800–3801, 3804–3805, 3828–3831, 3835–3841, 3878–3880, 3893–3894, 3903, 3943–3947, 3956
TOTAL193845276% 

Tests Skipped Failures Errors Time
185 3 💤 0 ❌ 0 🔥 11.372s ⏱️

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Aug 24, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution to the Slack integration. I've reviewed the changes and noticed a few minor issues to iron out. Specifically, there is a mismatch between the override_message in the code and the expected error message in the unit tests, and the release notes need some formatting adjustments to align with our guidelines. Thanks again for your work on this!

@mmhw, @omerKarkKatz, @hyaffe839 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/Slack/Integrations/SlackV3/SlackV3_test.py Outdated
Comment thread Packs/Slack/Integrations/SlackV3/SlackV3.py Outdated
Comment thread Packs/Slack/Integrations/SlackV3/SlackV3.py Outdated
Comment thread Packs/Slack/ReleaseNotes/3_8_18.md Outdated
Comment thread Packs/Slack/ReleaseNotes/3_8_18.md Outdated
Comment thread Packs/Slack/ReleaseNotes/3_8_18.md Outdated
@content-bot

This comment has been minimized.

@mmhw mmhw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just pay attention to my single comment.

Comment thread Packs/Slack/Integrations/SlackV3/SlackV3.py
@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: 2f9038a227735083

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants