Aggregate command block-domain - #45619
Conversation
The pan-os-create-address command already reads the create_tag argument in Panorama.py, but it was missing from the command's YAML arguments, so the platform stripped it before execution. Declaring it (mirroring the deprecated panorama-create-address command) lets callers auto-create tags that do not yet exist instead of failing.
nbensalm-palo
added
ready-for-pipeline-running
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
Coverage Report
|
||||||||||||||||||||||||||||||
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your work on the BlockDomain script.
I've left a few notes to help polish the contribution, mainly around standardizing the YAML context paths (e.g., BlockDomain.Result.*), formatting the argument descriptions, and syncing the README. For the Python code, please add the missing type hints, ensure full tracebacks are logged during exceptions, and address a potential AttributeError.
Thanks again for the great work!
Additionally, please address the following file-level notes:
Packs/AggregatedScripts/pack_metadata.json: The vendor name (e.g., 'Cortex' or 'Palo Alto Networks') is missing from thekeywordslist. Please add it to improve searchability.
@nbensalm-palo please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Validate summary Verdict: PR can be force merged from validate perspective? ❌ |
Shellyber
left a comment
Shellyber
left a comment
There was a problem hiding this comment.
Didn't look at the code yet, will do after the demo + changes.
Let's add doc review as well
|
|
||
| ##### New: block-domain | ||
|
|
||
| - Added the **block-domain** script, which blocks one or more domains across your configured security products. |
There was a problem hiding this comment.
Let's mention that it currently supports only panorama
| timeout: 20m0s | ||
| type: python | ||
| subtype: python3 | ||
| compliantpolicies: |
There was a problem hiding this comment.
Let's remove this for now and ignore the validation.
We will probably add block domain policy arorund Q2
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
5 participants
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/CRTX-250429
Description
Added the block-domain script, which blocks one or more domains across your configured security products.
Must have