Skip to content

CRTX-257648 - ESXi crond subtype-1 remove invalid outcome value - #45617

Open
akshotiamit-pa wants to merge 5 commits into
masterfrom
CRTX-257648-esxi-crond-outcome-remove-subtype
Open

CRTX-257648 - ESXi crond subtype-1 remove invalid outcome value#45617
akshotiamit-pa wants to merge 5 commits into
masterfrom
CRTX-257648-esxi-crond-outcome-remove-subtype

Conversation

@akshotiamit-pa

Copy link
Copy Markdown
Contributor

CRTX-257648 (B1)

ESXi crond subtype-1 (event_type=150, event_sub_type=1, _product=Esxi) set the story outcome column to the literal crond process start, outside the allowed enum {SUCCESS, FAILED, UNKNOWN, NULL}, in 100% of rows.

Root cause: the crond block set xdm.event.operation_sub_type = "crond process start", and the virtualization story model surfaces operation_sub_type into the outcome column. A crond start line reports no result, so the enum-correct value is NULL.

Fix

Removed the operation_sub_type assignment for the crond block. xdm.event.operation = OPERATION_TYPE_PROCESS_START and source.process.name = crond are retained, so process-start semantics and crond identity are preserved; outcome becomes NULL.

Verified on xdr-us-85898001 (read-only)

  • 100% of crond subtype-1 rows carried crond process start; 0 of 533,204 rows (3d, all distinct commands) contain any success/failure result.
  • crond filter matches exactly one log shape, so this is the most specific fix.

Satisfies AC1 + AC6. B2 (name/path) was fixed previously and is untouched.

…apture names

The parsing rule built RE2 named-capture groups from changedValues[].name.
Confluence audit field names contain dots (e.g. audit.logging.change.space.content.mode),
which RE2 rejects in group names -> 'invalid named capture' runtime error.
Add \. to the replex sanitize alternation so dots become underscores.
Verified on tenant xdr-eu-2006800998707: the sole non-empty failing row carried a dotted name.
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@akshotiamit-pa akshotiamit-pa added docs-approved bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Aug 23, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Aug 23, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer

This comment was marked as outdated.

@akshotiamit-pa akshotiamit-pa added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Aug 23, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Aug 23, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer

This comment was marked as outdated.

@content-bot

Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • VMwareESXi pack version was bumped to 1.0.21.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: 50e7be45fce76c85

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

@akshotiamit-pa akshotiamit-pa added research-mapping-approve This changes is belongs to research mapping. ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Aug 24, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Aug 24, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! No issues found. Great work! 👍

@marketplace-ai-reviewer, @akshotiamit-pa please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines research-mapping-approve This changes is belongs to research mapping.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants