Skip to content

Sk csp break return type - #45610

Draft
shmuel44 wants to merge 4 commits into
masterfrom
sk_csp_break_return_type
Draft

Sk csp break return type#45610
shmuel44 wants to merge 4 commits into
masterfrom
sk_csp_break_return_type

Conversation

@shmuel44

Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

Must have

  • Tests
  • Documentation

Deliberate breaking change for CIAC-17274 AI-adjudication testing. The function now returns a list wrapping the war room entry dict instead of the dict itself, breaking callers that index or return it directly. Disposable test branch, MUST NOT be merged.
@content-bot

content-bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

CommonServerPython dependency impact

Impacted content items were found and need manual verification.

  • Changed symbols: 1
  • Public entrypoints: 1
  • Affected files: 9
  • Affected packs: 5

CommonScripts

  • Packs/CommonScripts/Scripts/ExportToXLSX/ExportToXLSX.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/PDFUnlocker/PDFUnlocker.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/UnPackFile/UnPackFile.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/script-PCAPMiner.yml - matched: file_result_existing_file

GoogleCloudStorage

  • Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.py - matched: file_result_existing_file

ReversingLabs_A1000

  • Packs/ReversingLabs_A1000/Integrations/ReversingLabsA1000/ReversingLabsA1000.py - matched: file_result_existing_file

ThreatZone

  • Packs/ThreatZone/Integrations/ThreatZone/ThreatZone.py - matched: file_result_existing_file

Zoom

  • Packs/Zoom/Integrations/Zoom/Zoom.py - matched: file_result_existing_file

Open the HTML impact checklist

To accept this change without verifying each item, apply one of these PR labels: I'm okay with it, not-relevant-for-csp-validation.

Analyzed commit b4a6aaf7 · generated 2026-08-23T20:34:41Z · CI job

@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions

Copy link
Copy Markdown

⚠️ CommonServerPython change detected

This PR modifies one of the runtime-injected helper scripts (CommonServerPython.py / CommonServerPowerShell.ps1 / CommonServer.js).
A change here can impact every integration and script in the repository, so the standard PR pipeline is not enough.

Required before merge:

  1. Trigger the content nightly pipeline against this branch.
  2. Make sure the nightly run is green (all jobs passed).
  3. Add the nightly-run-passed label to this PR so this check turns green.

If you believe nightly is not required for this change, please justify it in a PR comment and add the label to unblock the check.

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

Coverage

Tests Skipped Failures Errors Time
7287 269 💤 0 ❌ 0 🔥 5m 9s ⏱️

@content-bot

Copy link
Copy Markdown
Contributor

CommonServerPython dependency impact

The AI adjudication stage confirmed 1 breaking file.

Adjudicated: 1 breaking, 0 warning, 8 safe.

Impacted content items were found and need manual verification.

  • Changed symbols: 1
  • Public entrypoints: 1
  • Affected files: 9
  • Affected packs: 5

The AI adjudication stage flagged these files as breaking:

File Confidence Why
Packs/ThreatZone/Integrations/ThreatZone/ThreatZone.py high The call at line 221 (inside Client._download_submission_asset, declared as returning dict) bubbles up through threatzone_get_sanitized_file/threatzone_get_html...

CommonScripts

  • Packs/CommonScripts/Scripts/ExportToXLSX/ExportToXLSX.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/PDFUnlocker/PDFUnlocker.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/UnPackFile/UnPackFile.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/script-PCAPMiner.yml - matched: file_result_existing_file

GoogleCloudStorage

  • Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.py - matched: file_result_existing_file

ReversingLabs_A1000

  • Packs/ReversingLabs_A1000/Integrations/ReversingLabsA1000/ReversingLabsA1000.py - matched: file_result_existing_file

ThreatZone

  • Packs/ThreatZone/Integrations/ThreatZone/ThreatZone.py - matched: file_result_existing_file

Zoom

  • Packs/Zoom/Integrations/Zoom/Zoom.py - matched: file_result_existing_file

Open the HTML impact checklist

To accept this change without verifying each item, apply one of these PR labels: I'm okay with it, not-relevant-for-csp-validation.

Analyzed commit 05af24f8 · generated 2026-08-23T10:50:27Z · CI job

@content-bot

This comment has been minimized.

@content-bot

Copy link
Copy Markdown
Contributor

CommonServerPython dependency impact

The AI adjudication stage confirmed 1 breaking file.

Adjudicated: 1 breaking, 2 warning, 6 safe.

Impacted content items were found and need manual verification.

  • Changed symbols: 1
  • Public entrypoints: 1
  • Affected files: 9
  • Affected packs: 5

The AI adjudication stage flagged these files as breaking:

File Confidence Why
Packs/ThreatZone/Integrations/ThreatZone/ThreatZone.py high Line 221 (return file_result_existing_file(filename)) is the return statement of Client._download_submission_asset, whose return type is annotated -> dict a...

CommonScripts

  • Packs/CommonScripts/Scripts/ExportToXLSX/ExportToXLSX.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/PDFUnlocker/PDFUnlocker.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/UnPackFile/UnPackFile.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/script-PCAPMiner.yml - matched: file_result_existing_file

GoogleCloudStorage

  • Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.py - matched: file_result_existing_file

ReversingLabs_A1000

  • Packs/ReversingLabs_A1000/Integrations/ReversingLabsA1000/ReversingLabsA1000.py - matched: file_result_existing_file

ThreatZone

  • Packs/ThreatZone/Integrations/ThreatZone/ThreatZone.py - matched: file_result_existing_file

Zoom

  • Packs/Zoom/Integrations/Zoom/Zoom.py - matched: file_result_existing_file

Open the HTML impact checklist

To accept this change without verifying each item, apply one of these PR labels: I'm okay with it, not-relevant-for-csp-validation.

Analyzed commit 212030d5 · generated 2026-08-23T16:48:47Z · CI job

@content-bot

This comment has been minimized.

@content-bot

Copy link
Copy Markdown
Contributor

⚠️ The PR is missing the ready-for-pipeline-running label. Please add the label when the PR is ready in order to proceed.

@content-bot

Copy link
Copy Markdown
Contributor

CommonServerPython dependency impact

The AI adjudication stage confirmed 1 breaking file.

Adjudicated: 1 breaking, 2 warning, 6 safe.

Impacted content items were found and need manual verification.

  • Changed symbols: 1
  • Public entrypoints: 1
  • Affected files: 9
  • Affected packs: 5

The AI adjudication stage flagged these files as breaking:

File Confidence Why
Packs/ThreatZone/Integrations/ThreatZone/ThreatZone.py high At line 221, _download_submission_asset returns file_result_existing_file(filename), whose result now flows (via threatzone_get_sanitized_file) into the `...

CommonScripts

  • Packs/CommonScripts/Scripts/ExportToXLSX/ExportToXLSX.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/PDFUnlocker/PDFUnlocker.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/UnPackFile/UnPackFile.py - matched: file_result_existing_file
  • Packs/CommonScripts/Scripts/script-PCAPMiner.yml - matched: file_result_existing_file

GoogleCloudStorage

  • Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.py - matched: file_result_existing_file

ReversingLabs_A1000

  • Packs/ReversingLabs_A1000/Integrations/ReversingLabsA1000/ReversingLabsA1000.py - matched: file_result_existing_file

ThreatZone

  • Packs/ThreatZone/Integrations/ThreatZone/ThreatZone.py - matched: file_result_existing_file

Zoom

  • Packs/Zoom/Integrations/Zoom/Zoom.py - matched: file_result_existing_file

Open the HTML impact checklist

To accept this change without verifying each item, apply one of these PR labels: I'm okay with it, not-relevant-for-csp-validation.

Analyzed commit b4a6aaf7 · generated 2026-08-23T20:34:41Z · CI job

@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: RN106, PA114.
The following errors cannot be ignored: RN106, PA114.
The following errors don't run as part of the nightly flow and therefore can be force merged: RN106, PA114.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: ee67ba968240189e

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants