Skip to content

Tests fail when using large (but valid) share_adjustment #171

Description

@dpaiton

#170 highlights that using the upper-bound on share_adjustment when generating a random state causes a set of tests to fail:

test lp::math::tests::fuzz_calculate_net_curve_trade_safe
test lp::math::tests::fuzz_calculate_present_value
test long::max::tests::fuzz_sol_calculate_max_long
test short::open::tests::test_defaults_calculate_spot_price_after_short

After an initial inspection, @jalextowle concluded that at least the fuzz_sol_calculate_max_long, fuzz_calculate_present_value, and fuzz_calculate_net_curve_trade_safe failures indicate a discrepancy between Rust and Solidity.

We need to dig into each test and correct it or the underlying code it is testing.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions