Add S3 persisted-data integrity verification - #172
Merged
Conversation
Declare the nested storage.integrity subtree in the engine base schema and defaults, disabled by default, and prove it resolves end to end against the shipped configuration. Add a CLI probe of the existing GET /config/schema endpoint that requires the four integrity paths before a verification scenario is submitted. Engine startup rejection and the scenario POST are unreliable substitutes: startup argument handling can continue past an invalid path, and an integrity-unaware engine rejects the scenario later with an opaque HTTP 400. The probe checks path presence only, because confuse schema leaves are type descriptors. Implements row 0a and part of INT-ID-001/INT-DIRECT-001.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add persisted-data integrity verification for S3 through the new
write-verifyandread-verifycorrectness workloads. SPT writes versioned SHA-256 metadata with generated objects, verifies complete GET responses, distinguishes corruption with exit code20, and retains canonical, crash-durable manifests and resumable evidence.The implementation supports immediate write/read verification, CREATE-only seeding with
--defer-verification, later LIST- or manifest-driven verification, verified-only cleanup, multipart uploads, Netty and AWS S3 drivers, and the RDMA software path. It also adds typed run plans, explicit lifecycle ownership, distributed image/payload identity gates, interruption-safe finalization and cleanup, credential-safe run evidence, and runnable direct-JAR scenarios.Automatic discovery intentionally selects current object versions only. Exact historical versions may be supplied in canonical manifests; automatic all-version discovery is deferred to a follow-up release.
Accepted qualification limits