fix(python): avoid userdata reference cycle in FUSE demo - #421
Open
030611 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #386.
The FUSE demo passes the full io tuple as userdata. That tuple contains the same iovec wrapper being prepared, while the C++ iov retains userdata through completion. This creates a wrapper -> C++ iov -> tuple -> wrapper cycle across the Python/C++ boundary.
Pass the expected byte count as scalar userdata instead, preserving the existing completion check without retaining the wrapper. Also clarify the userdata lifetime contract in the binding documentation.
Validation:
I could not run the FUSE/RDMA path locally. This does not change usrbio runtime ownership and does not address the separate prepare() error path.