fix(packaging): remove git dependency from package version - #420
Open
030611 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #343.
The generated source distribution runs
git rev-parsefromsetup.py, but an unpacked sdist has no.gitdirectory. That makes even package metadata commands fail before the native extension build starts.This removes the unused revision suffix and keeps the package version at
1.2.9, matching the published sdist metadata. The regression test builds an sdist from a temporary Git checkout, extracts it outside Git, and verifies thatsetup.py --versionandPKG-INFOboth report1.2.9.This intentionally makes source-checkout metadata match the published version instead of adding a local
+<sha>suffix.Tested with:
pytest tests/test_setup.py(1 passed)