-
Notifications
You must be signed in to change notification settings - Fork 641
fix(pt_expt): reuse the stored min_nbor_dist and batch the neighbor statistics #5956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yckbz
wants to merge
9
commits into
deepmodeling:master
Choose a base branch
from
yckbz:fix-pt-expt-min-nbor-dist
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
15a0b34
fix(pt_expt): read min_nbor_dist from @variables
yckbz 110e60b
fix(pt_expt): batch the neighbor statistics
yckbz 6681b32
Potential fix for pull request finding
yckbz 12e34ad
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7d14eae
Merge branch 'master' into fix-pt-expt-min-nbor-dist
yckbz 0c88b50
fix(pt_expt): follow the selected device when auto-batching
yckbz d850ca9
fix(pt_expt): keep min_nbor_dist in the graph-lower output
yckbz f1423c1
fix(pt_expt): assign min_nbor_dist through the spin backbone
yckbz cbb5117
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # SPDX-License-Identifier: LGPL-3.0-or-later | ||
|
|
||
| from deepmd.pt.utils.auto_batch_size import AutoBatchSize as AutoBatchSizeBase | ||
| from deepmd.pt_expt.utils.env import ( | ||
| DEVICE, | ||
| ) | ||
|
|
||
|
|
||
| class AutoBatchSize(AutoBatchSizeBase): | ||
| """Auto batch size following the device pt_expt runs on. | ||
|
|
||
| ``DEVICE`` is CPU whenever ``DEVICE=cpu`` is set, even on a CUDA host. | ||
| Growing the batch there risks a host OOM, which the CUDA-OOM handler | ||
| cannot recover from, so the growth policy follows the selected device | ||
| rather than CUDA availability. | ||
| """ | ||
|
|
||
| def is_gpu_available(self) -> bool: | ||
| """Check if the selected device is a GPU. | ||
|
|
||
| Returns | ||
| ------- | ||
| bool | ||
| True if pt_expt runs on a CUDA device | ||
| """ | ||
| return DEVICE.type == "cuda" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.