-
Notifications
You must be signed in to change notification settings - Fork 319
multi: Add getmixpoolinfo RPC. #3720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jholdstock
wants to merge
3
commits into
decred:master
Choose a base branch
from
jholdstock:getmixinfo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally rather see this, at the very least, match
types.Vin.ScriptSigso it has the actual script hex and decoded asm. Particularly because, and I hadn't noticed this until now, the string the wire message uses is inconsistent with the naming used bystdscriptand isn't really descriptive enough either.P2PKH-secp256k1-v0doesn't tell you one of the most important parts -- the signature scheme (ecdsa). Noticestdscriptcalls themp2pkh-ecdsa-secp256k1andp2pkh-schnorr-secp256k1specifically to differentiate.More generally, I think maybe even the entire
types.Vinstruct would make sense for each utxo. There are some cases that would obviously not apply (e.g. coinbase, stakebase, treasurybase, treasuryspend), but it has a bunch of details about the referenced utxo like its transaction hash, output index, tree, amountin, blockheight, blockindex,scriptSig.asm, andscriptSig.hex.That would also make it more consistent with
getrawtransaction,decoderawtransaction, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be uncovering a wider bug because that string representation is not only used in the wire message but also in the compatibility matching (
CompatiblePRsmatches usingPairing).Given that the
Pairing.ScriptClassfield of the new RPC response is intended to describe the values used for compatibility matching, and not the individual UTXOs necessarily, I believe it is correct as-is.In order to give more detail to the returned UTXOs we could include the values from wire.MixPairReqUTXO quite easily?