secp256k1: Add field mulbyx methods.#3716
Merged
Merged
Conversation
jholdstock
reviewed
Jul 8, 2026
davecgh
force-pushed
the
secp256k1_field_mulby
branch
2 times, most recently
from
July 8, 2026 04:46
9c2b8cc to
c6dedf1
Compare
jholdstock
approved these changes
Jul 8, 2026
dcr-approvals-proxy
approved these changes
Jul 13, 2026
This adds new MulBy2, MulBy3, MulBy4, and MulBy8 methods to FieldVal so the API is more consistent with the new FieldVal64 type and pave the way for eventually being able select the backend field. Unlike the FieldVal64 implementations where the specialized methods provide a speed advantage, the FieldVal implementations simply defer to MulInt since it is faster due to the fact it doesn't immediately reduce or do carry propagation.
This adds a test for the new MulBy2, MulBy3, MulBy4, and MulBy8 methods added to FieldVal.
davecgh
force-pushed
the
secp256k1_field_mulby
branch
from
July 15, 2026 21:07
c6dedf1 to
696f667
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3710.This adds new
MulBy2,MulBy3,MulBy4, andMulBy8methods toFieldValso the API is more consistent with the newFieldVal64type and pave the way for eventually being able to select the backend field.Unlike the
FieldVal64implementations where the specialized methods provide a speed advantage, theFieldValimplementations simply defer toMulIntsince it is faster due to the fact it doesn't immediately reduce or do carry propagation.It also includes benchmarks and tests for the new methods as well as a new benchmark for
MulIntfor comparison.