multi: Replace reflect.Ptr with reflect.Pointer.#3715
Open
jholdstock wants to merge 2 commits into
Open
Conversation
go 1.18 renamed reflect.Ptr to reflect.Pointer in order to be more consistent with the rest of the reflect package.
go 1.18 renamed reflect.Ptr to reflect.Pointer in order to be more consistent with the rest of the reflect package.
jholdstock
changed the title
davecgh
reviewed
Jun 30, 2026
davecgh
left a comment
davecgh
left a comment
Member
There was a problem hiding this comment.
No objections once go.mod is eventually bumped. Looks fine.
davecgh
changed the title
davecgh
added
the
Waiting for forced newer Go version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR because updating the linter to 2.12 throws an error about using the old name, I think because of this and this.
The conversation about updating
go.modversion has already been had in #3053 and #3054 (and many times in other places), but I'm opening this PR anyway so it can be merged at some point in the future when the update to >=1.18 eventually does happen.