linux 6.12.103-10: strip canister Kconfig symbols when fips=0 - #14
linux 6.12.103-10: strip canister Kconfig symbols when fips=0#14dcasota wants to merge 1 commit into
Conversation
|
Part of the Photon 5.0 installer/build fix set tracked for replication to
Installer-source changes upstreamed at dcasota/photon-os-installer#7 (interactive install) and dcasota/photon-os-installer#8 (tdnf output capture). |
7f89e9c to
296f247
Compare
When fips=0 (aarch64 default, or an explicit x86_64 override) neither the
canister_build nor the canister_usage branch in %prep runs, so the patch
that introduces the GCC_PLUGIN_{MATCH,PAD}_CANISTER_STRUCTS Kconfig symbols
is never applied. The shipped .config still carries their "is not set"
comments, `make olddefconfig` silently drops them, and the
check_for_config_applicability.inc diff guard then fails %prep.
Strip the two comments up-front when fips=0 so the diff stays clean.
Rebased from 6.12.87-2 onto 6.12.103-9; the defect is unchanged in the
current spec.
Change-Id: I5d3f88bbd23b0157915f3d4af36be99b1e254722
Signed-off-by: Daniel Casota <dcasota@gmail.com>
296f247 to
d1bc645
Compare
|
Superseded by #24. #24 moves this same fix into the new shared One behavioural note: #24 replaces this PR's broad sed with linux-esx's narrower pair matching only the The two PRs touch the same lines and will conflict, so only one should be merged. #24 is the one to take; this can be closed once that is confirmed. |
|
Closing as superseded by #24, after verifying equivalence across the full permutation set rather than by inspection. Behavioural equivalence — 36/36 cells identical. Compared the expanded
Sed-form equivalence — proven, not assumed. The branch-selection matrix above only shows the same branches fire; the two PRs use textually different seds there. This PR's broad form and #24's narrower pair were therefore executed against every shipped kernel config: They agree because no config contains a #24 is a strict superset. It also repairs No dependencies. No open PR in this fork or in vmware/photon uses Nothing is lost by closing this; take #24 instead. |
Rebased from 6.12.87-2 onto the current 5.0 head (6.12.103-9), which clears the CONFLICTING state this PR had been sitting in.
The defect (unchanged upstream)
When
fips=0— the aarch64 default, or an explicit x86_64 override — neither the%if 0%{?canister_build}nor the%if 0%{?canister_usage}branch in%prepruns, so the patch that introduces theGCC_PLUGIN_{MATCH,PAD}_CANISTER_STRUCTSKconfig symbols is never applied. The shipped.configstill carries theiris not setcomments,make olddefconfigsilently drops them, and thecheck_for_config_applicability.incdiff guard then fails%prep.Verified still present on
vmware/photon@5.0at 6.12.103-10: the canister seds sit at lines 692-697 guarded only bycanister_build/canister_usage, with nofips=0path.The change
One guarded
sedin%prepthat strips the two comments up-front whenfips=0, plus the release bump and changelog entry.Passes
support/spec-checker/check_spec.pycleanly (exit 0).