make asset and opengraph paths deployment-origin aware - #7
Merged
Conversation
- make vite assets use relative URLs (we were sloppily setting viteOptions.base before, but it wasn't working for things like Netlify branch deploys) - compute a deployOrigin based on Netlify and Eleventy env vars and use that to make og:url and og:image use absoluate URLs with deployment-appropriate origins - I couldn't find a clean/simple way to use fingerprinted assets output from Vite use deployment-origin aware absolute URLs, so instead I made a duplicate copy of the avatar image that lives in public (and is therefore not fingerprinted) so we can pipe it through a filter to make it absolute The downside of this approach is a second copy of the same image, but it won't be loaded in the browser, only for things trying to generate an OpenGraph preview (i.e., 2 copies, but only one should ever be loaded by any given client).
✅ Deploy Preview for danebertram ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downside of this approach is a second copy of the same image, but it won't be loaded in the browser, only for things trying to generate an OpenGraph preview (i.e., 2 copies, but only one should ever be loaded by any given client).