chore: drop no-op allow-unfree settings and bump nixpkgs to 26.05 - #11
Draft
0xgleb wants to merge 2 commits into
Draft
chore: drop no-op allow-unfree settings and bump nixpkgs to 26.05#110xgleb wants to merge 2 commits into
0xgleb wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
`allow-unfree` is not a Nix setting -- `nix config show` does not list it and Nix warns "unknown setting 'allow-unfree'" when the flake declares it, so the nixConfig entry only cost a trust prompt. NIXPKGS_ALLOW_UNFREE was equally redundant: gitbutler-cli is permitted by the allowUnfreePredicate on this flake's own nixpkgs import, which is where the derivation is constructed. Both the package and the devShell evaluate with neither set.
Tracks the current stable channel instead of the previous release, so upgrades stay incremental rather than accumulating into one large jump. Also switches the devShell to pkgs.nixfmt: nixfmt-rfc-style is an alias on this channel and evaluating it warns. nix flake check passes, including the pr-stack-footer nushell suite.
0xgleb
force-pushed
the
fix/drop-dead-unfree-settings
branch
from
August 12, 2026 21:28
fbcbb4e to
ab81b78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The flake carried an
allow-unfree = truenixConfigentry and aNIXPKGS_ALLOW_UNFREE=1export in.envrc, and consuming repos were copying both on the assumption that packaging an unfree binary required them. Neither does anything here, so the pattern was spreading a cargo-culted trust prompt to every consumer.Separately, the lock tracked the previous stable channel. Letting that drift means upgrades arrive as one large, awkward jump instead of small incremental ones.
Solution
allow-unfreefromnixConfig. It is not a Nix setting:nix config showdoes not list it, and Nix emitswarning: unknown setting 'allow-unfree'when a flake declares it.NIXPKGS_ALLOW_UNFREEfrom.envrc.gitbutler-cliis permitted by theallowUnfreePredicateon this flake's own nixpkgs import, which is where the derivation is constructed; a consumer only references the finished derivation, so its own nixpkgs config never enters into it.nixos-26.05, and switch the devShell topkgs.nixfmt--nixfmt-rfc-styleis an alias on this channel and evaluating it warns.Verified with
nix flake check(buildsgitbutler-cliand runs thepr-stack-footernushell suite) and by evaluating both the package and the devShell withNIXPKGS_ALLOW_UNFREEunset.