Skip to content

chore: drop no-op allow-unfree settings and bump nixpkgs to 26.05 - #11

Draft
0xgleb wants to merge 2 commits into
masterfrom
fix/drop-dead-unfree-settings
Draft

chore: drop no-op allow-unfree settings and bump nixpkgs to 26.05#11
0xgleb wants to merge 2 commits into
masterfrom
fix/drop-dead-unfree-settings

Conversation

@0xgleb

@0xgleb 0xgleb commented Aug 12, 2026

Copy link
Copy Markdown
Member

Motivation

The flake carried an allow-unfree = true nixConfig entry and a NIXPKGS_ALLOW_UNFREE=1 export in .envrc, and consuming repos were copying both on the assumption that packaging an unfree binary required them. Neither does anything here, so the pattern was spreading a cargo-culted trust prompt to every consumer.

Separately, the lock tracked the previous stable channel. Letting that drift means upgrades arrive as one large, awkward jump instead of small incremental ones.

Solution

  • Drop allow-unfree from nixConfig. It is not a Nix setting: nix config show does not list it, and Nix emits warning: unknown setting 'allow-unfree' when a flake declares it.
  • Drop NIXPKGS_ALLOW_UNFREE from .envrc. gitbutler-cli is permitted by the allowUnfreePredicate on this flake's own nixpkgs import, which is where the derivation is constructed; a consumer only references the finished derivation, so its own nixpkgs config never enters into it.
  • Bump nixpkgs to nixos-26.05, and switch the devShell to pkgs.nixfmt -- nixfmt-rfc-style is an alias on this channel and evaluating it warns.

Verified with nix flake check (builds gitbutler-cli and runs the pr-stack-footer nushell suite) and by evaluating both the package and the devShell with NIXPKGS_ALLOW_UNFREE unset.

@0xgleb 0xgleb self-assigned this Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 409cdd64-921e-4685-8cba-819b56c4e244

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

0xgleb added 2 commits August 12, 2026 18:28
`allow-unfree` is not a Nix setting -- `nix config show` does not list it and Nix warns "unknown setting 'allow-unfree'" when the flake declares it, so the nixConfig entry only cost a trust prompt. NIXPKGS_ALLOW_UNFREE was equally redundant: gitbutler-cli is permitted by the allowUnfreePredicate on this flake's own nixpkgs import, which is where the derivation is constructed. Both the package and the devShell evaluate with neither set.
Tracks the current stable channel instead of the previous release, so upgrades stay incremental rather than accumulating into one large jump. Also switches the devShell to pkgs.nixfmt: nixfmt-rfc-style is an alias on this channel and evaluating it warns. nix flake check passes, including the pr-stack-footer nushell suite.
@0xgleb
0xgleb force-pushed the fix/drop-dead-unfree-settings branch from fbcbb4e to ab81b78 Compare August 12, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant