Stop reconfiguring the root logger when importing DQX#1359
Merged
mwojtyczka merged 5 commits intoJul 24, 2026
Merged
Conversation
SreeramaYeshwanthGowd
requested review from
pratikk-databricks
and removed request for
a team
July 22, 2026 11:22
SreeramaYeshwanthGowd
force-pushed
the
fix/1136-root-logger-reconfigure
branch
from
July 22, 2026 11:34
f84617d to
ff49bd3
Compare
mwojtyczka
added
the
under-review
mwojtyczka
added
Approved to Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Importing anything from DQX currently reconfigures the Python root logger, because
src/databricks/labs/dqx/__init__.pycalls blueprint'sinstall_logger()at import time, which removes all existing root handlers and installs its own. That overwrites the logging setup of any application using DQX as a library (see #1136).This changes the package import to leave the root logger alone. Following standard library logging practice, it attaches a
NullHandlerto thedatabricks.labs.dqxlogger instead of installing a handler on the root logger. The CLI is unaffected; it configures logging separately viaget_logger/install_loggerincli.pyandinstaller/logs.py.Linked issues
Resolves #1136
Tests
Unit tests in
tests/unit/test_logging_setup.pycheck that importing DQX does not remove the application's root handlers or change the root level, and that aNullHandleris attached to thedatabricks.labs.dqxlogger.Documentation and Demos