Expand flowx: Airflow source, coverage reporting, notify motifs, and translation restructure - #22
Closed
matthewmoorcroft wants to merge 2 commits into
Closed
Expand flowx: Airflow source, coverage reporting, notify motifs, and translation restructure#22matthewmoorcroft wants to merge 2 commits into
matthewmoorcroft wants to merge 2 commits into
Conversation
Brings the full internal flowx development line into databricks-solutions/flowx as a single clean snapshot, establishing this repo as the single source of truth (the two repos had forked into parallel development). Internal features folded in (59 commits' worth): Apache Airflow migration source, source-audit reconciliation + coverage reporting, pydabs-dbt-factory hooks, notify motifs, metadata-driven consolidation, and the engine -> sources/adf restructure with serialization extracted to ir_serde. The public repo's own global-parameters feature (bundle_variables / hoisted globals / global_parameter_resolution) is preserved and unioned in throughout (session options, dab_writer, prereqs_writer, workflow_preparer, ir, ir_serde). Published as a squashed snapshot rather than the raw internal history so no internal/customer identifiers leak into public git history. Identifiers scrubbed from the snapshot: a customer engagement code (test fixtures/names), an employee test Azure SQL host, a real ADLS account name, a real Azure subscription GUID, and internal test resource-group / factory names — all replaced with neutral placeholders. Verified: 1194 unit tests pass; ruff + mypy clean. Co-authored-by: Isaac <no-reply@databricks.com>
Rewrite internal package-proxy URLs (pypi-proxy.dev.databricks.com) to pypi.org / files.pythonhosted.org so public CI resolves deps. Same pinned versions and hashes; matches main. Co-authored-by: Isaac <no-reply@databricks.com>
Member
Author
|
@ghanse Can we get this merged, need it in to reconcile my other PRs with this repo and get them ready to merge |
ghanse
approved these changes
Sep 4, 2026
ghanse
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for putting this together, this LGTM.
ghanse
added a commit
that referenced
this pull request
Sep 4, 2026
## Changes <!-- Summary of your changes that are easy to understand. Add screenshots when necessary --> This PR is based on #22 and merges internal changes into the flowx repo: * Airflow support (@peterpark-db) * Fix missing notebook headers in bridge notebooks (@lorenzorubi-db ) * Emit `sync.include` in generated `databricks.yml` (@alexnastetsky ) * Fixes to documentation (@zanitarahimi) * Consolidation and conflict resolution (@matthewmoorcroft ) * Updates to GitHub actions (@matthewmoorcroft and @ghanse ) ### Linked issues <!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> Resolves #18 ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] manually tested - [x] added unit tests - [x] added integration tests --------- Co-authored-by: matthewmoorcroft <31916486+matthewmoorcroft@users.noreply.github.com>
Collaborator
|
Closed by #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A substantial expansion of flowx's capabilities plus a cleaner module structure, building on the existing global-parameters support.
What's new
sources/adf/, with IR serialization extracted intoir_serde.The existing global-parameters support (
bundle_variables/ hoisted globals /global_parameter_resolution) is preserved and integrated throughout (sessionoptions,dab_writer,prereqs_writer,workflow_preparer,ir,ir_serde).Verification
ruff+mypyclean.Reviewer notes
skills/*/SKILL.md) restructured; detailed content now lives underskills/*/sources/*.md..github/workflows/left unchanged.uv.lockregenerated against the updatedpyproject.toml.global_parameter_resolutionis gated to theadfsource.This pull request and its description were written by Isaac.