Fix TLD time import crash, incomplete crt.sh/Yandex enum, and AAAA SE results - #579
Open
jandrusk wants to merge 7 commits into
Open
Fix TLD time import crash, incomplete crt.sh/Yandex enum, and AAAA SE results#579jandrusk wants to merge 7 commits into
jandrusk wants to merge 7 commits into
Conversation
Several enumeration paths still produced incomplete or broken results: - brute_tlds used time.strftime without importing time, crashing TLD mode - se_result_process dropped AAAA answers despite resolving them via get_ip - crt.sh parsing only used common_name and discarded wildcards/apex names - Yandex scraping never advanced pages (same URL every iteration) Add unit coverage for each fix.
- Import time so TLD brute force duration estimates no longer NameError - Include AAAA answers in se_result_process (was A/CNAME only) - Restore test_dnsrecon.py with coverage for both behaviors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several enumeration bugs still present on current master:
import timeincli.py—brute_tlds()callstime.strftime/time.gmtimeand crashes withNameErrorwhen estimating duration.se_result_processdocstring says A/AAAA but only keptAandCNAME.common_name, skipped SANname_valuefields, discarded wildcards, and skipped the apex domain. Now parses both fields, de-stars wildcards, and accepts the apex.p=<page>.Test plan
tests/test_crtenum.py)p=pagination (tests/test_yandexenum.py)timeimport coverage (tests/test_dnsrecon.py,tests/test_cli_regressions.py)Verification