ci: bump actions/cache to v5 - #676
Conversation
![prelint[bot]](https://avatars.githubusercontent.com/in/2822344?s=60&v=4){kind=small}
📋 PR Overview
🔬 Coverage
|
🎨 Storybook previewUpdated for 6aa23b6
|
darkmatteragent
left a comment
darkmatteragent
left a comment
There was a problem hiding this comment.
Review — COMMENT
7688ae312251 · 1 finding
Comment: all four bumped pins verify correct, but the v4→v5 sweep is incomplete — the repo has six cache pins, not the four the PR description claims. One missed pin remains outside .github/.
.depot/actions/setup/action.ymlstill pinsrestore@v4(L92) andsave@v4(L225) in a stale pre-refactor monolith copy; bump or delete it.- Verified safe: v5 emits
cache-primary-key/cache-hitidentically (NullStateProvider), archive format is unchanged, and save failures still log as warnings — theif: always()sccache save cannot newly fail jobs. - No consumer of the
.depotcopy was found in-repo or org-wide, so impact is consistency, not a live break.
Findings
Important
minor · ci — actions/cache v4→v5 migration misses the .depot copy: restore@v4 (L92) and save@v4 (L225)
.depot/actions/setup/action.yml:92
Line 92 uses: actions/cache/restore@v4 and line 225 uses: actions/cache/save@v4 in .depot/actions/setup/action.yml. Repo-wide code search shows actions/cache in exactly three files; this PR bumps the other two and its description claims "Covers all four pins: build.yaml and the setup-devenv composite" — the repo actually contains six cache pins. This file is a stale snapshot of the pre-ref
Important minor · ci — actions/cache v4→v5 migration misses the .depot copy: restore@v4 (L92) and save@v4 (L225) Line 92 reviewed: 7688ae3 — 2026-08-31T18:25Z verdict: comment findings: 1
Run details
|
||||||||||||||||||||||||||||
Problem: v4 targets the Node 20 runtime, which is deprecated on GitHub Actions runners; runs emit a deprecation warning while the runner force-runs the action on Node 24. Solution: v5 targets Node 24 natively; inputs and cache format are unchanged. Covers all six pins: build.yaml, the setup-devenv composite, and the .depot setup copy. Only requirement is runner >= 2.327.1; observed runners are at 2.336.0 (self-hosted macOS) and 2.335.1 (arc).
7688ae3 to
6aa23b6
Compare
|
Fair comment. Fixed |
2 participants
Summary
Problem: v4 targets the Node 20 runtime, which is deprecated on GitHub Actions runners; runs emit a deprecation warning while the runner force-runs the action on Node 24.
Solution: v5 targets Node 24 natively; inputs and cache format are unchanged. Covers all four pins: build.yaml and the setup-devenv composite. Only requirement is runner >= 2.327.1; observed runners are at 2.336.0 (self-hosted macOS) and 2.335.1 (arc).
Test Plan
Docs