fix: refactor loop - #346
Merged
Merged
Conversation
Signed-off-by: Mike Nguyen <hey@mike.ee>
Contributor
There was a problem hiding this comment.
✅ Ready to approve
The change is a behavior-preserving refactor (dropping an unused key binding) and is low risk.
Note: this review does not count toward required approvals for merging.
Pull request overview
This PR refactors the route-configuration loop in the actor runtime to iterate directly over registered actor type values instead of (key, value) pairs, keeping behavior the same while simplifying the code.
Changes:
- Replace
types.iter_mut()withtypes.values_mut()inconfigure_method_routesto avoid binding an unused map key.
File summaries
| File | Description |
|---|---|
dapr/src/server/actor/runtime/mod.rs |
Simplifies iteration over the actor registration map when draining and applying method registrations. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
This PR will close #number
Checklist