🛑 fix: Preserve BYOM Foreground Cancellation Identity - #15777
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…oreground-run-identity # Conflicts: # api/server/services/Endpoints/agents/initialize.js
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
I fixed foreground Stop propagation for attached BYOM commands by binding cancellation ownership to the response-scoped runtime message identity rather than the user message ID carried by the incoming HTTP request.
run_id.Change Type
Testing
cd packages/api && npx jest src/agents/handlers.spec.ts --runInBand -t "run cancellation"cd packages/api && npx tsc --noEmit -p tsconfig.jsoncd api && npx jest server/services/Endpoints/agents/initialize.spec.js --runInBand --no-cache -t "binds foreground tool execution"cd api && npx jest server/controllers/agents/__tests__/request.resumeMetadata.spec.js --runInBandcd api && npx jest server/controllers/agents/__tests__/resume.spec.js --runInBand -t "seeds the thread parent before reconstruction"npm run static-checksTest Configuration:
Checklist