feat(testkit): tool-list-changed assertion helper (MC-47) - #32
Merged
Merged
Conversation
jgangemi
enabled auto-merge (squash)
July 12, 2026 21:17
Coverage Report for CI Build 29209544104Coverage increased (+0.05%) to 96.284%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
- wire mcpx.ClientOptions.OnToolListChanged into testkit.Harness at New(), signaling a buffered non-blocking channel on each notification - add Harness.WaitForToolListChanged(timeout) bool: waits for at least one notifications/tools/list_changed within timeout, false on timeout - add AssertToolListChanged(t, h, timeout) test-failing wrapper, matching AssertToolSet/EventuallyContains' t-taking style - refactor MC-45's TestLockBeforeConnectThenUnlockAtRuntime to use testkit.Harness + the new helper instead of a hand-built raw mcpx.Client - add TestHarnessToolListChanged_Timeout and _Signaled covering both WaitForToolListChanged branches directly in the testkit package Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jgangemi
force-pushed
the
jae/mc47-listchanged-helper
branch
from
July 12, 2026 21:23
fbccbf5 to
71c815e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signaling a buffered non-blocking channel on each notification
notifications/tools/list_changed within timeout, false on timeout
AssertToolSet/EventuallyContains' t-taking style
testkit.Harness + the new helper instead of a hand-built raw mcpx.Client
WaitForToolListChanged branches directly in the testkit package
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com