feat(cli): standard --read-only flag on ServerCmd (MC-46) - #29
Merged
Merged
Conversation
- register --read-only (bool, default false) unconditionally on ServerCmd, unlike --http/--stateless which are gated on Server.HTTP != nil, since it gates tool registration rather than transport - in RunE, before the transport starts, --read-only calls App.Gate(mcpkit.ReadOnlyMode()) so write/destructive tools are never registered - reserve the read-only flag name the same way as http/stateless: register it on cmd.Flags() before Server.Flags runs, so a colliding Server.Flags registration panics via pflag at construction - UseAsDefault's existing flag-copy makes --read-only work on both `myapp server --read-only` and bare `myapp --read-only` - update package/doc comments and regenerate cli/README.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jgangemi
enabled auto-merge (squash)
July 12, 2026 20:33
Coverage Report for CI Build 29207952449Coverage increased (+0.02%) to 96.192%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unlike --http/--stateless which are gated on Server.HTTP != nil, since it
gates tool registration rather than transport
App.Gate(mcpkit.ReadOnlyMode()) so write/destructive tools are never
registered
it on cmd.Flags() before Server.Flags runs, so a colliding Server.Flags
registration panics via pflag at construction
myapp server --read-onlyand baremyapp --read-onlyCo-Authored-By: Claude Opus 4.8 noreply@anthropic.com