Repository navigation
Add "Ends at" time display. - #475
Merged
Merged
Conversation
|
Is this going to be placed inside the play button? |
damontecres
requested changes
Dec 16, 2025
damontecres
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution!
I'm putting this to request changes because I want to think about how best to manage/track the current time throughout the app's interface. This implementation sets the end time, but won't update after the initial display. But having multiple places tracking the current time needs some thought to be before fixing this.
I'll definitely come back to this soon.
Owner
|
#493 will unblock this, there's an example of how to use it in that PR When you update this PR, can you provide some screenshots? Thanks! |
damontecres
added a commit
that referenced
this pull request
Dec 17, 2025
## Description
Creates a `CompositionLocal` which tracks the current time in a single
place and is usable anywhere in the app.
Can be used such as:
```kotlin
val now = LocalClock.current.now
val details = remember(item, now) {
// Create detail strings based the item and current time
// This will be recomposed/updated whenever the time changes
}
```
### Related issues
Related to #475
asandhu3
force-pushed
the
add-end-time
branch
from
December 17, 2025 21:23
db94e5d to
8561f13
Compare
Contributor
Author
asandhu3
force-pushed
the
add-end-time
branch
from
December 17, 2025 22:13
4bd5661 to
7d8ccb0
Compare
Owner
damontecres
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Addresses #441 .